Re: [Qemu-devel] [PATCH 12/13] MC146818 RTC: add GPIO access to output IRQ

2016-06-17 Thread Paolo Bonzini
On 17/06/2016 15:11, Efimov Vasily wrote: > qdev_init_nofail(dev); > if (intercept_irq) { > -s->irq = intercept_irq; > +qdev_connect_gpio_out(dev, 0, intercept_irq); > } else { > isa_init_irq(isadev, &s->irq, RTC_ISA_IRQ); > } Please introduce a wrapp

[Qemu-devel] [PATCH 12/13] MC146818 RTC: add GPIO access to output IRQ

2016-06-17 Thread Efimov Vasily
The MC146818 RTC device has output IRQ line. Currently the corresponding field is only accessible through direct access. Such access violates Qemu model. The patch makes the field accessible through GPIO. It also updates the setting of the IRQ during initialization in case of IRQ intercepting. Si