On Wed, Apr 03, 2013 at 10:09:25PM +0200, Igor Mammedov wrote:
> On Wed, 3 Apr 2013 16:27:11 -0300
> Eduardo Habkost wrote:
>
> > On Wed, Apr 03, 2013 at 08:59:07PM +0200, Igor Mammedov wrote:
> > > On Wed, 3 Apr 2013 15:10:05 -0300
> > > Eduardo Habkost wrote:
> > >
> > > > On Wed, Apr 03, 201
On Wed, 3 Apr 2013 16:27:11 -0300
Eduardo Habkost wrote:
> On Wed, Apr 03, 2013 at 08:59:07PM +0200, Igor Mammedov wrote:
> > On Wed, 3 Apr 2013 15:10:05 -0300
> > Eduardo Habkost wrote:
> >
> > > On Wed, Apr 03, 2013 at 07:58:00PM +0200, Igor Mammedov wrote:
> > >
> > > > > > +void do_cpu_hot
On Wed, Apr 03, 2013 at 08:59:07PM +0200, Igor Mammedov wrote:
> On Wed, 3 Apr 2013 15:10:05 -0300
> Eduardo Habkost wrote:
>
> > On Wed, Apr 03, 2013 at 07:58:00PM +0200, Igor Mammedov wrote:
> >
> > > > > +void do_cpu_hot_add(const int64_t id, Error **errp)
> > > > > +{
> > > > > +pc_new_c
On Wed, 03 Apr 2013 20:22:17 +0200
Andreas Färber wrote:
> Am 03.04.2013 19:58, schrieb Igor Mammedov:
> > On Wed, 27 Mar 2013 12:19:01 +0100
> > Paolo Bonzini wrote:
> >
> >> Il 21/03/2013 15:28, Igor Mammedov ha scritto:
> >>> +if (x86_cpu_is_cpu_exist(qdev_get_machine(), &apic_id)) {
> >
On Wed, 3 Apr 2013 15:10:05 -0300
Eduardo Habkost wrote:
> On Wed, Apr 03, 2013 at 07:58:00PM +0200, Igor Mammedov wrote:
>
> > > > +void do_cpu_hot_add(const int64_t id, Error **errp)
> > > > +{
> > > > +pc_new_cpu(saved_cpu_model, id, errp);
> > > > +}
> > > > +
> > >
> > > Missing x86_cp
On Wed, Apr 03, 2013 at 07:58:00PM +0200, Igor Mammedov wrote:
> > > +void do_cpu_hot_add(const int64_t id, Error **errp)
> > > +{
> > > +pc_new_cpu(saved_cpu_model, id, errp);
> > > +}
> > > +
> >
> > Missing x86_cpu_apic_id_from_index(id)?
> There was(is?) opposition to using cpu_index to i
Am 03.04.2013 19:58, schrieb Igor Mammedov:
> On Wed, 27 Mar 2013 12:19:01 +0100
> Paolo Bonzini wrote:
>
>> Il 21/03/2013 15:28, Igor Mammedov ha scritto:
>>> +if (x86_cpu_is_cpu_exist(qdev_get_machine(), &apic_id)) {
>>
>> Similarly, can this be done in qmp_cpu_set? And should it really be
On Wed, 27 Mar 2013 12:19:01 +0100
Paolo Bonzini wrote:
> Il 21/03/2013 15:28, Igor Mammedov ha scritto:
> > ... via do_cpu_hot_add() hook called by cpu_set QMP command,
> > for x86 target.
> >
> > * add extra check that APIC ID is in allowed range
> > * return error if CPU with requested APIC I
Il 21/03/2013 15:28, Igor Mammedov ha scritto:
> ... via do_cpu_hot_add() hook called by cpu_set QMP command,
> for x86 target.
>
> * add extra check that APIC ID is in allowed range
> * return error if CPU with requested APIC ID exists before creating
> a new instance. (CPU removal is broken no
On Thu, 21 Mar 2013 20:46:57 -0600
Eric Blake wrote:
> On 03/21/2013 08:28 AM, Igor Mammedov wrote:
> > ... via do_cpu_hot_add() hook called by cpu_set QMP command,
> > for x86 target.
> >
> > * add extra check that APIC ID is in allowed range
>
> > +if (x86_cpu_is_cpu_exist(qdev_get_machin
On 03/21/2013 08:28 AM, Igor Mammedov wrote:
> ... via do_cpu_hot_add() hook called by cpu_set QMP command,
> for x86 target.
>
> * add extra check that APIC ID is in allowed range
> +if (x86_cpu_is_cpu_exist(qdev_get_machine(), &apic_id)) {
> +error_setg(errp, "Unable to add CPU with
... via do_cpu_hot_add() hook called by cpu_set QMP command,
for x86 target.
* add extra check that APIC ID is in allowed range
* return error if CPU with requested APIC ID exists before creating
a new instance. (CPU removal is broken now, will be fixed with CPU unplug)
* call CPU add notifier a
12 matches
Mail list logo