Re: [Qemu-devel] [PATCH 12/12] hw/pci-host/apb.c: Avoid shifting left into sign bit

On Mon, Mar 10, 2014 at 07:10:48PM +, Peter Maydell wrote: > Add U suffix to avoid undefined behaviour. > > Signed-off-by: Peter Maydell While not required for correctness, it would be cleaner to change all constants around this line to 1U <<, for consistency. > --- > hw/pci-host/apb.c | 2

[Qemu-devel] [PATCH 12/12] hw/pci-host/apb.c: Avoid shifting left into sign bit

Add U suffix to avoid undefined behaviour. Signed-off-by: Peter Maydell --- hw/pci-host/apb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/pci-host/apb.c b/hw/pci-host/apb.c index 1b399dd..a6869b8 100644 --- a/hw/pci-host/apb.c +++ b/hw/pci-host/apb.c @@ -58,7 +58,7 @@