Re: [Qemu-devel] [PATCH 11/56] check-qjson: Cover UTF-8 in single quoted strings

2018-08-13 Thread Markus Armbruster
Eric Blake writes: > On 08/13/2018 01:11 AM, Markus Armbruster wrote: > > Technically, Unicode ends at U+10 (21 bits). Anything beyond that > is not valid Unicode, even if it IS a valid interpretation of UTF-8 > encoding. Correct. Testing how we handle such sequences ma

Re: [Qemu-devel] [PATCH 11/56] check-qjson: Cover UTF-8 in single quoted strings

2018-08-13 Thread Eric Blake
On 08/13/2018 01:11 AM, Markus Armbruster wrote: Technically, Unicode ends at U+10 (21 bits). Anything beyond that is not valid Unicode, even if it IS a valid interpretation of UTF-8 encoding. Correct. Testing how we handle such sequences makes sense all the same. { -

Re: [Qemu-devel] [PATCH 11/56] check-qjson: Cover UTF-8 in single quoted strings

2018-08-12 Thread Markus Armbruster
Eric Blake writes: > On 08/10/2018 09:18 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> On 08/08/2018 07:02 AM, Markus Armbruster wrote: utf8_string() tests only double quoted strings. Cover single quoted strings, too: store the strings to test without quotes, then wrap the

Re: [Qemu-devel] [PATCH 11/56] check-qjson: Cover UTF-8 in single quoted strings

2018-08-10 Thread Eric Blake
On 08/10/2018 09:18 AM, Markus Armbruster wrote: Eric Blake writes: On 08/08/2018 07:02 AM, Markus Armbruster wrote: utf8_string() tests only double quoted strings. Cover single quoted strings, too: store the strings to test without quotes, then wrap them in either kind of quote. Signed-off

Re: [Qemu-devel] [PATCH 11/56] check-qjson: Cover UTF-8 in single quoted strings

2018-08-10 Thread Markus Armbruster
Eric Blake writes: > On 08/08/2018 07:02 AM, Markus Armbruster wrote: >> utf8_string() tests only double quoted strings. Cover single quoted >> strings, too: store the strings to test without quotes, then wrap them >> in either kind of quote. >> >> Signed-off-by: Markus Armbruster >> --- >> t

Re: [Qemu-devel] [PATCH 11/56] check-qjson: Cover UTF-8 in single quoted strings

2018-08-09 Thread Eric Blake
On 08/08/2018 07:02 AM, Markus Armbruster wrote: utf8_string() tests only double quoted strings. Cover single quoted strings, too: store the strings to test without quotes, then wrap them in either kind of quote. Signed-off-by: Markus Armbruster --- tests/check-qjson.c | 427

[Qemu-devel] [PATCH 11/56] check-qjson: Cover UTF-8 in single quoted strings

2018-08-08 Thread Markus Armbruster
utf8_string() tests only double quoted strings. Cover single quoted strings, too: store the strings to test without quotes, then wrap them in either kind of quote. Signed-off-by: Markus Armbruster --- tests/check-qjson.c | 427 ++-- 1 file changed, 214 in