Re: [Qemu-devel] [PATCH 11/13] Move pci_parse_devaddr to qdev-properties

2012-06-08 Thread Andreas Färber
Am 08.06.2012 15:55, schrieb Anthony Liguori: > On 06/07/2012 08:57 PM, Andreas Färber wrote: >> Am 04.06.2012 10:52, schrieb Jan Kiszka: >>> We will some use this function also for property parsing, so move it >>> over unmodified and rename it. >>> >>> Signed-off-by: Jan Kiszka >> >> These last th

Re: [Qemu-devel] [PATCH 11/13] Move pci_parse_devaddr to qdev-properties

2012-06-08 Thread Anthony Liguori
On 06/08/2012 10:17 PM, Michael S. Tsirkin wrote: On Fri, Jun 08, 2012 at 02:45:47PM +0200, Jan Kiszka wrote: On 2012-06-08 14:18, Andreas Färber wrote: Am 08.06.2012 14:14, schrieb Jan Kiszka: On 2012-06-08 14:03, Andreas Färber wrote: Can't understand that you're trying to push your v1 so h

Re: [Qemu-devel] [PATCH 11/13] Move pci_parse_devaddr to qdev-properties

2012-06-08 Thread Michael S. Tsirkin
On Fri, Jun 08, 2012 at 02:45:47PM +0200, Jan Kiszka wrote: > On 2012-06-08 14:18, Andreas Färber wrote: > > Am 08.06.2012 14:14, schrieb Jan Kiszka: > >> On 2012-06-08 14:03, Andreas Färber wrote: > >>> Can't understand that you're trying to push your v1 so hard now when our > >>> series have been

Re: [Qemu-devel] [PATCH 11/13] Move pci_parse_devaddr to qdev-properties

2012-06-08 Thread Anthony Liguori
On 06/07/2012 08:57 PM, Andreas Färber wrote: Am 04.06.2012 10:52, schrieb Jan Kiszka: We will some use this function also for property parsing, so move it over unmodified and rename it. Signed-off-by: Jan Kiszka These last three patches collide with Paolo's QOM properties refactoring: qdev p

Re: [Qemu-devel] [PATCH 11/13] Move pci_parse_devaddr to qdev-properties

2012-06-08 Thread Jan Kiszka
On 2012-06-08 14:18, Andreas Färber wrote: > Am 08.06.2012 14:14, schrieb Jan Kiszka: >> On 2012-06-08 14:03, Andreas Färber wrote: >>> Can't understand that you're trying to push your v1 so hard now when our >>> series have been on the list for much longer. ;) >> >> I explained the reason, and I t

Re: [Qemu-devel] [PATCH 11/13] Move pci_parse_devaddr to qdev-properties

2012-06-08 Thread Andreas Färber
Am 08.06.2012 14:14, schrieb Jan Kiszka: > On 2012-06-08 14:03, Andreas Färber wrote: >> Can't understand that you're trying to push your v1 so hard now when our >> series have been on the list for much longer. ;) > > I explained the reason, and I think my patches (minus the dropped one) > are rea

Re: [Qemu-devel] [PATCH 11/13] Move pci_parse_devaddr to qdev-properties

2012-06-08 Thread Jan Kiszka
On 2012-06-08 14:03, Andreas Färber wrote: > Am 08.06.2012 12:57, schrieb Jan Kiszka: >> On 2012-06-07 17:56, Andreas Färber wrote: >>> Am 07.06.2012 17:11, schrieb Jan Kiszka: On 2012-06-07 14:57, Andreas Färber wrote: > These last three patches collide with Paolo's QOM properties >

Re: [Qemu-devel] [PATCH 11/13] Move pci_parse_devaddr to qdev-properties

2012-06-08 Thread Andreas Färber
Am 08.06.2012 12:57, schrieb Jan Kiszka: > On 2012-06-07 17:56, Andreas Färber wrote: >> Am 07.06.2012 17:11, schrieb Jan Kiszka: >>> On 2012-06-07 14:57, Andreas Färber wrote: These last three patches collide with Paolo's QOM properties refactoring: qdev properties are being generalized

Re: [Qemu-devel] [PATCH 11/13] Move pci_parse_devaddr to qdev-properties

2012-06-08 Thread Jan Kiszka
On 2012-06-07 17:56, Andreas Färber wrote: > Am 07.06.2012 17:11, schrieb Jan Kiszka: >> On 2012-06-07 14:57, Andreas Färber wrote: >>> These last three patches collide with Paolo's QOM properties >>> refactoring: qdev properties are being generalized to Object and >>> on my GitHub "realize" branc

Re: [Qemu-devel] [PATCH 11/13] Move pci_parse_devaddr to qdev-properties

2012-06-07 Thread Andreas Färber
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 07.06.2012 17:11, schrieb Jan Kiszka: > On 2012-06-07 14:57, Andreas Färber wrote: >> These last three patches collide with Paolo's QOM properties >> refactoring: qdev properties are being generalized to Object and >> on my GitHub "realize" branch

Re: [Qemu-devel] [PATCH 11/13] Move pci_parse_devaddr to qdev-properties

2012-06-07 Thread Jan Kiszka
On 2012-06-07 14:57, Andreas Färber wrote: > Am 04.06.2012 10:52, schrieb Jan Kiszka: >> We will some use this function also for property parsing, so move it >> over unmodified and rename it. >> >> Signed-off-by: Jan Kiszka > > These last three patches collide with Paolo's QOM properties > refact

Re: [Qemu-devel] [PATCH 11/13] Move pci_parse_devaddr to qdev-properties

2012-06-07 Thread Andreas Färber
Am 04.06.2012 10:52, schrieb Jan Kiszka: > We will some use this function also for property parsing, so move it > over unmodified and rename it. > > Signed-off-by: Jan Kiszka These last three patches collide with Paolo's QOM properties refactoring: qdev properties are being generalized to Object

[Qemu-devel] [PATCH 11/13] Move pci_parse_devaddr to qdev-properties

2012-06-04 Thread Jan Kiszka
We will some use this function also for property parsing, so move it over unmodified and rename it. Signed-off-by: Jan Kiszka --- hw/pci-hotplug.c |2 +- hw/pci.c | 67 +- hw/pci.h |5 --- hw/qdev-properties.c