Re: [Qemu-devel] [PATCH 11/12] mc146818rtc: add missed field to vmstate

2014-08-26 Thread Paolo Bonzini
Il 26/08/2014 09:15, Pavel Dovgalyuk ha scritto: > +static int rtc_pre_load(void *opaque) > +{ > +RTCState *s = (RTCState *)opaque; > +s->irq_reinject_on_ack_count = 0; > +return 0; > +} > + You found a real bug here, in that the field has to be cleared at reset time. But reinitializi

[Qemu-devel] [PATCH 11/12] mc146818rtc: add missed field to vmstate

2014-08-26 Thread Pavel Dovgalyuk
This patch adds irq_reinject_on_ack_count field to VMState to allow correct saving/loading the state of MC146818 RTC. Signed-off-by: Pavel Dovgalyuk --- hw/timer/mc146818rtc.c | 32 1 files changed, 32 insertions(+), 0 deletions(-) diff --git a/hw/timer/mc1468