Re: [Qemu-devel] [PATCH 10/17] target: Clean up how the dump_mmu() print

2019-04-15 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Markus Armbruster (arm...@redhat.com) wrote: >> The various dump_mmu() take an fprintf()-like callback and a FILE * to >> pass to it, and so do their helper functions. Passing around callback >> and argument is rather tiresome. >> >> Most dump_mmu() are call

Re: [Qemu-devel] [PATCH 10/17] target: Clean up how the dump_mmu() print

2019-04-15 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > The various dump_mmu() take an fprintf()-like callback and a FILE * to > pass to it, and so do their helper functions. Passing around callback > and argument is rather tiresome. > > Most dump_mmu() are called only by the target's hmp_info_tlb(). T

[Qemu-devel] [PATCH 10/17] target: Clean up how the dump_mmu() print

2019-04-11 Thread Markus Armbruster
The various dump_mmu() take an fprintf()-like callback and a FILE * to pass to it, and so do their helper functions. Passing around callback and argument is rather tiresome. Most dump_mmu() are called only by the target's hmp_info_tlb(). These all pass monitor_printf() cast to fprintf_function a