Re: [Qemu-devel] [PATCH 10/15] smbios: Add a function to directly add an entry

2015-04-14 Thread Paolo Bonzini
On 14/04/2015 08:31, Michael S. Tsirkin wrote: > On Mon, Apr 13, 2015 at 06:40:46PM +0200, Paolo Bonzini wrote: >> >> >> On 13/04/2015 18:34, Corey Minyard wrote: > I made this the same as the ACPI code, which you have to have as a > callback if you are adding it to a common SSDT. >>

Re: [Qemu-devel] [PATCH 10/15] smbios: Add a function to directly add an entry

2015-04-14 Thread Corey Minyard
On 04/14/2015 01:31 AM, Michael S. Tsirkin wrote: > On Mon, Apr 13, 2015 at 06:40:46PM +0200, Paolo Bonzini wrote: >> >> On 13/04/2015 18:34, Corey Minyard wrote: > I made this the same as the ACPI code, which you have to have as a > callback if you are adding it to a common SSDT. Not

Re: [Qemu-devel] [PATCH 10/15] smbios: Add a function to directly add an entry

2015-04-13 Thread Michael S. Tsirkin
On Mon, Apr 13, 2015 at 11:34:49AM -0500, Corey Minyard wrote: > On 04/13/2015 02:00 AM, Michael S. Tsirkin wrote: > > On Sun, Apr 12, 2015 at 08:26:46PM -0500, Corey Minyard wrote: > >> On 04/12/2015 11:05 AM, Michael S. Tsirkin wrote: > >>> On Tue, Apr 07, 2015 at 02:51:39PM -0500, miny...@acm.or

Re: [Qemu-devel] [PATCH 10/15] smbios: Add a function to directly add an entry

2015-04-13 Thread Michael S. Tsirkin
On Mon, Apr 13, 2015 at 06:40:46PM +0200, Paolo Bonzini wrote: > > > On 13/04/2015 18:34, Corey Minyard wrote: > > > > I made this the same as the ACPI code, which you have to have as a > > > > callback if you are adding it to a common SSDT. > > > > > > Not really I think. > > > > The AML functio

Re: [Qemu-devel] [PATCH 10/15] smbios: Add a function to directly add an entry

2015-04-13 Thread Paolo Bonzini
On 13/04/2015 18:34, Corey Minyard wrote: > > > I made this the same as the ACPI code, which you have to have as a > > > callback if you are adding it to a common SSDT. > > > > Not really I think. > > The AML functions require that you have a tree to attach what you are > adding. If you did your

Re: [Qemu-devel] [PATCH 10/15] smbios: Add a function to directly add an entry

2015-04-13 Thread Corey Minyard
On 04/13/2015 02:00 AM, Michael S. Tsirkin wrote: > On Sun, Apr 12, 2015 at 08:26:46PM -0500, Corey Minyard wrote: >> On 04/12/2015 11:05 AM, Michael S. Tsirkin wrote: >>> On Tue, Apr 07, 2015 at 02:51:39PM -0500, miny...@acm.org wrote: From: Corey Minyard There was no way to direct

Re: [Qemu-devel] [PATCH 10/15] smbios: Add a function to directly add an entry

2015-04-13 Thread Michael S. Tsirkin
On Sun, Apr 12, 2015 at 08:26:46PM -0500, Corey Minyard wrote: > On 04/12/2015 11:05 AM, Michael S. Tsirkin wrote: > > On Tue, Apr 07, 2015 at 02:51:39PM -0500, miny...@acm.org wrote: > >> From: Corey Minyard > >> > >> There was no way to directly add a table entry to the SMBIOS table, > >> even t

Re: [Qemu-devel] [PATCH 10/15] smbios: Add a function to directly add an entry

2015-04-12 Thread Corey Minyard
On 04/12/2015 11:05 AM, Michael S. Tsirkin wrote: > On Tue, Apr 07, 2015 at 02:51:39PM -0500, miny...@acm.org wrote: >> From: Corey Minyard >> >> There was no way to directly add a table entry to the SMBIOS table, >> even though the BIOS supports this. So add a function to do this. >> This is in

Re: [Qemu-devel] [PATCH 10/15] smbios: Add a function to directly add an entry

2015-04-12 Thread Michael S. Tsirkin
On Tue, Apr 07, 2015 at 02:51:39PM -0500, miny...@acm.org wrote: > From: Corey Minyard > > There was no way to directly add a table entry to the SMBIOS table, > even though the BIOS supports this. So add a function to do this. > This is in preparation for the IPMI handler adding it's SMBIOS tabl

[Qemu-devel] [PATCH 10/15] smbios: Add a function to directly add an entry

2015-04-07 Thread minyard
From: Corey Minyard There was no way to directly add a table entry to the SMBIOS table, even though the BIOS supports this. So add a function to do this. This is in preparation for the IPMI handler adding it's SMBIOS table entry. Signed-off-by: Corey Minyard --- hw/i386/smbios.c | 149