Re: [Qemu-devel] [PATCH 10/11] qdev: Add do_info_qbus and friends.

2009-12-29 Thread Nathan Baum
On Tue, 2009-12-29 at 15:13 -0200, Luiz Capitulino wrote: > > +qdict_put(qdict, "gpio-in", qint_from_int(dev->num_gpio_in)); > > +qdict_put(qdict, "gpio-out", qint_from_int(dev->num_gpio_out)); > > Is this a boolean? If so you should use qbool_from_int(). It isn't, but they shouldn't be

Re: [Qemu-devel] [PATCH 10/11] qdev: Add do_info_qbus and friends.

2009-12-29 Thread Luiz Capitulino
On Sat, 26 Dec 2009 21:19:21 + Nathan Baum wrote: > Places information about a bus and the devices on into a QObject. > > Signed-off-by: Nathan Baum > --- > hw/qdev.c | 73 > + > 1 files changed, 73 insertions(+), 0 deletions(-

[Qemu-devel] [PATCH 10/11] qdev: Add do_info_qbus and friends.

2009-12-26 Thread Nathan Baum
Places information about a bus and the devices on into a QObject. Signed-off-by: Nathan Baum --- hw/qdev.c | 73 + 1 files changed, 73 insertions(+), 0 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index b6bd4ae..f5d68c6 100644 ---