Re: [Qemu-devel] [PATCH 1.1] qemu-ga: fix segv after failure to open log file

2012-05-15 Thread Luiz Capitulino
On Tue, 15 May 2012 09:14:13 -0500 Michael Roth wrote: > On Tue, May 15, 2012 at 10:04:32AM -0300, Luiz Capitulino wrote: > > On Mon, 14 May 2012 17:04:17 -0500 > > Michael Roth wrote: > > > > > Currently, if we fail to open the specified log file (generally due to a > > > permissions issue), w

Re: [Qemu-devel] [PATCH 1.1] qemu-ga: fix segv after failure to open log file

2012-05-15 Thread Peter Maydell
On 15 May 2012 15:22, Michael Roth wrote: > On Tue, May 15, 2012 at 02:32:41PM +0100, Peter Maydell wrote: >> On 14 May 2012 23:04, Michael Roth wrote: >> > Currently, if we fail to open the specified log file (generally due to a >> > permissions issue), we'll assign NULL to the logfile handle (s

Re: [Qemu-devel] [PATCH 1.1] qemu-ga: fix segv after failure to open log file

2012-05-15 Thread Michael Roth
On Tue, May 15, 2012 at 02:32:41PM +0100, Peter Maydell wrote: > On 14 May 2012 23:04, Michael Roth wrote: > > Currently, if we fail to open the specified log file (generally due to a > > permissions issue), we'll assign NULL to the logfile handle (stderr, > > initially) used by the logging routin

Re: [Qemu-devel] [PATCH 1.1] qemu-ga: fix segv after failure to open log file

2012-05-15 Thread Michael Roth
On Tue, May 15, 2012 at 10:04:32AM -0300, Luiz Capitulino wrote: > On Mon, 14 May 2012 17:04:17 -0500 > Michael Roth wrote: > > > Currently, if we fail to open the specified log file (generally due to a > > permissions issue), we'll assign NULL to the logfile handle (stderr, > > initially) used b

Re: [Qemu-devel] [PATCH 1.1] qemu-ga: fix segv after failure to open log file

2012-05-15 Thread Peter Maydell
On 14 May 2012 23:04, Michael Roth wrote: > Currently, if we fail to open the specified log file (generally due to a > permissions issue), we'll assign NULL to the logfile handle (stderr, > initially) used by the logging routines, which can cause a segfault to > occur when we attempt to report the

Re: [Qemu-devel] [PATCH 1.1] qemu-ga: fix segv after failure to open log file

2012-05-15 Thread Luiz Capitulino
On Mon, 14 May 2012 17:04:17 -0500 Michael Roth wrote: > Currently, if we fail to open the specified log file (generally due to a > permissions issue), we'll assign NULL to the logfile handle (stderr, > initially) used by the logging routines, which can cause a segfault to > occur when we attempt

Re: [Qemu-devel] [PATCH 1.1] qemu-ga: fix segv after failure to open log file

2012-05-15 Thread Michal Privoznik
On 15.05.2012 00:04, Michael Roth wrote: > Currently, if we fail to open the specified log file (generally due to a > permissions issue), we'll assign NULL to the logfile handle (stderr, > initially) used by the logging routines, which can cause a segfault to > occur when we attempt to report the e

[Qemu-devel] [PATCH 1.1] qemu-ga: fix segv after failure to open log file

2012-05-14 Thread Michael Roth
Currently, if we fail to open the specified log file (generally due to a permissions issue), we'll assign NULL to the logfile handle (stderr, initially) used by the logging routines, which can cause a segfault to occur when we attempt to report the error before exiting. Instead, only re-assign if