Re: [Qemu-devel] [PATCH 1/9] target/arm: Implement vector shifted SCVF/UCVF for fp16

2018-04-29 Thread Peter Maydell
On 29 April 2018 at 15:44, Richard Henderson wrote: > On 04/27/2018 11:04 AM, Alex Bennée wrote: >> >> Richard Henderson writes: >>> +elements = 8 << is_q >> size; >> >> That is a brain exercise for operator precedence. Would: >> >> elements = (is_q ? 16 : 8) >> size; >> >> be cleare

Re: [Qemu-devel] [PATCH 1/9] target/arm: Implement vector shifted SCVF/UCVF for fp16

2018-04-29 Thread Richard Henderson
On 04/27/2018 11:04 AM, Alex Bennée wrote: > > Richard Henderson writes: > >> While we have some of the scalar paths for *CVF for fp16, >> we failed to decode the fp16 version of these instructions. >> >> Signed-off-by: Richard Henderson >> --- >> target/arm/translate-a64.c | 33 ++

Re: [Qemu-devel] [PATCH 1/9] target/arm: Implement vector shifted SCVF/UCVF for fp16

2018-04-27 Thread Alex Bennée
Richard Henderson writes: > While we have some of the scalar paths for *CVF for fp16, > we failed to decode the fp16 version of these instructions. > > Signed-off-by: Richard Henderson > --- > target/arm/translate-a64.c | 33 - > 1 file changed, 20 insertions(+)

[Qemu-devel] [PATCH 1/9] target/arm: Implement vector shifted SCVF/UCVF for fp16

2018-04-24 Thread Richard Henderson
While we have some of the scalar paths for *CVF for fp16, we failed to decode the fp16 version of these instructions. Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 33 - 1 file changed, 20 insertions(+), 13 deletions(-) diff --git a/target/arm