Re: [Qemu-devel] [PATCH 1/9] Export function for VA defined ram allocation

2009-10-21 Thread Carsten Otte
Anthony Liguori wrote: However, an ugly #ifdef immediately tells someone, oh, s390 kvm needs this terrible hack, so let's keep bugging those guys to eliminate the need for that. /me moves cleaning up memslot handling a little further up the prio list. I fear it still won't make it to queue head

Re: [Qemu-devel] [PATCH 1/9] Export function for VA defined ram allocation

2009-10-21 Thread Anthony Liguori
Alexander Graf wrote: On 21.10.2009, at 20:06, Anthony Liguori wrote: Alexander Graf wrote: So you would prefer a special #ifdef for s390 in generic code over a specifically for this purpose exported function? Well, you're the boss. I like the special function better, but whatever you say.

Re: [Qemu-devel] [PATCH 1/9] Export function for VA defined ram allocation

2009-10-21 Thread Alexander Graf
On 21.10.2009, at 20:06, Anthony Liguori wrote: Alexander Graf wrote: So you would prefer a special #ifdef for s390 in generic code over a specifically for this purpose exported function? Well, you're the boss. I like the special function better, but whatever you say. How is someone sup

Re: [Qemu-devel] [PATCH 1/9] Export function for VA defined ram allocation

2009-10-21 Thread Anthony Liguori
Alexander Graf wrote: So you would prefer a special #ifdef for s390 in generic code over a specifically for this purpose exported function? Well, you're the boss. I like the special function better, but whatever you say. How is someone supposed to figure out what _qemu_ram_alloc is for? No

Re: [Qemu-devel] [PATCH 1/9] Export function for VA defined ram allocation

2009-10-21 Thread Alexander Graf
On 21.10.2009, at 18:54, Anthony Liguori wrote: Alexander Graf wrote: On 21.10.2009, at 16:29, Anthony Liguori wrote: Alexander Graf wrote: S390 requires vmas for guests to be < 256 GB. So we need to directly export mmaps "try to use this vma as start address" feature to not accidently

Re: [Qemu-devel] [PATCH 1/9] Export function for VA defined ram allocation

2009-10-21 Thread Anthony Liguori
Alexander Graf wrote: On 21.10.2009, at 16:29, Anthony Liguori wrote: Alexander Graf wrote: S390 requires vmas for guests to be < 256 GB. So we need to directly export mmaps "try to use this vma as start address" feature to not accidently get over that limit. Signed-off-by: Alexander Graf

Re: [Qemu-devel] [PATCH 1/9] Export function for VA defined ram allocation

2009-10-21 Thread Alexander Graf
On 21.10.2009, at 16:29, Anthony Liguori wrote: Alexander Graf wrote: S390 requires vmas for guests to be < 256 GB. So we need to directly export mmaps "try to use this vma as start address" feature to not accidently get over that limit. Signed-off-by: Alexander Graf --- cpu-common.h |

Re: [Qemu-devel] [PATCH 1/9] Export function for VA defined ram allocation

2009-10-21 Thread Anthony Liguori
Alexander Graf wrote: S390 requires vmas for guests to be < 256 GB. So we need to directly export mmaps "try to use this vma as start address" feature to not accidently get over that limit. Signed-off-by: Alexander Graf --- cpu-common.h |1 + exec.c | 15 +-- 2 files ch

[Qemu-devel] [PATCH 1/9] Export function for VA defined ram allocation

2009-10-21 Thread Alexander Graf
S390 requires vmas for guests to be < 256 GB. So we need to directly export mmaps "try to use this vma as start address" feature to not accidently get over that limit. Signed-off-by: Alexander Graf --- cpu-common.h |1 + exec.c | 15 +-- 2 files changed, 14 insertions(+),

[Qemu-devel] [PATCH 1/9] Export function for VA defined ram allocation

2009-10-19 Thread Alexander Graf
S390 requires vmas for guests to be < 256 GB. So we need to directly export mmaps "try to use this vma as start address" feature to not accidently get over that limit. Signed-off-by: Alexander Graf --- cpu-common.h |1 + exec.c | 15 +-- 2 files changed, 14 insertions(+),