Re: [Qemu-devel] [PATCH 1/8] target-ppc: Bug Fix: rlwinm

2014-08-15 Thread Richard Henderson
On 08/15/2014 08:34 AM, Richard Henderson wrote: > On 08/11/2014 09:23 AM, Tom Musta wrote: >> The rlwinm specification includes the ROTL32 operation, which is defined >> to be a left rotation of two copies of the least significant 32 bits of >> the source GPR. >> >> The current implementation is i

Re: [Qemu-devel] [PATCH 1/8] target-ppc: Bug Fix: rlwinm

2014-08-15 Thread Richard Henderson
On 08/11/2014 09:23 AM, Tom Musta wrote: > The rlwinm specification includes the ROTL32 operation, which is defined > to be a left rotation of two copies of the least significant 32 bits of > the source GPR. > > The current implementation is incorrect on 64-bit implementations in that > it rotates

[Qemu-devel] [PATCH 1/8] target-ppc: Bug Fix: rlwinm

2014-08-11 Thread Tom Musta
The rlwinm specification includes the ROTL32 operation, which is defined to be a left rotation of two copies of the least significant 32 bits of the source GPR. The current implementation is incorrect on 64-bit implementations in that it rotates a single copy of the least significant 32 bits, padd