Re: [Qemu-devel] [PATCH 1/8] pci: Cleanup configuration for pci-hotplug.c

2013-05-24 Thread David Gibson
On Thu, May 23, 2013 at 04:54:17PM +0200, Paolo Bonzini wrote: > Il 09/05/2013 02:31, David Gibson ha scritto: > > diff --git a/hw/pci/Makefile.objs b/hw/pci/Makefile.objs > > index a7fb9d0..2ad32b6 100644 > > --- a/hw/pci/Makefile.objs > > +++ b/hw/pci/Makefile.objs > > @@ -8,4 +8,4 @@ common-obj-

Re: [Qemu-devel] [PATCH 1/8] pci: Cleanup configuration for pci-hotplug.c

2013-05-24 Thread David Gibson
On Thu, May 23, 2013 at 02:11:35PM +0300, Michael S. Tsirkin wrote: > On Thu, May 09, 2013 at 10:31:05AM +1000, David Gibson wrote: [snip] > > diff --git a/hw/pci/Makefile.objs b/hw/pci/Makefile.objs > > index a7fb9d0..2ad32b6 100644 > > --- a/hw/pci/Makefile.objs > > +++ b/hw/pci/Makefile.objs > >

Re: [Qemu-devel] [PATCH 1/8] pci: Cleanup configuration for pci-hotplug.c

2013-05-23 Thread Paolo Bonzini
Il 09/05/2013 02:31, David Gibson ha scritto: > diff --git a/hw/pci/Makefile.objs b/hw/pci/Makefile.objs > index a7fb9d0..2ad32b6 100644 > --- a/hw/pci/Makefile.objs > +++ b/hw/pci/Makefile.objs > @@ -8,4 +8,4 @@ common-obj-$(CONFIG_PCI) += pcie.o pcie_aer.o pcie_port.o > common-obj-$(CONFIG_NO_PC

Re: [Qemu-devel] [PATCH 1/8] pci: Cleanup configuration for pci-hotplug.c

2013-05-23 Thread David Gibson
On Thu, May 23, 2013 at 02:11:35PM +0300, Michael S. Tsirkin wrote: > On Thu, May 09, 2013 at 10:31:05AM +1000, David Gibson wrote: [snip] > > diff --git a/hw/pci/pci-hotplug-old.c b/hw/pci/pci-hotplug-old.c > > new file mode 100644 > > index 000..724a80b > > --- /dev/null > > +++ b/hw/pci/pci-

Re: [Qemu-devel] [PATCH 1/8] pci: Cleanup configuration for pci-hotplug.c

2013-05-23 Thread Michael S. Tsirkin
On Thu, May 09, 2013 at 10:31:05AM +1000, David Gibson wrote: > pci-hotplug.c and the CONFIG_PCI_HOTPLUG variable which controls its > compilation are misnamed. They're not about PCI hotplug in general, but > rather about the pci_add/pci_del interface which are now deprecated in > favour of the mo

[Qemu-devel] [PATCH 1/8] pci: Cleanup configuration for pci-hotplug.c

2013-05-08 Thread David Gibson
pci-hotplug.c and the CONFIG_PCI_HOTPLUG variable which controls its compilation are misnamed. They're not about PCI hotplug in general, but rather about the pci_add/pci_del interface which are now deprecated in favour of the more general device_add/device_del interface. This patch therefore rena