Re: [Qemu-devel] [PATCH 1/7] vmgenid: replace x-write-pointer-available hack

2017-07-03 Thread Michael S. Tsirkin
On Mon, Jul 03, 2017 at 03:50:52PM -0300, Eduardo Habkost wrote: > On Mon, Jul 03, 2017 at 09:38:52PM +0300, Michael S. Tsirkin wrote: > > On Thu, Jun 29, 2017 at 03:23:04PM +0200, Marc-André Lureau wrote: > > > This compat property sole function is to prevent the device from being > > > instantiat

Re: [Qemu-devel] [PATCH 1/7] vmgenid: replace x-write-pointer-available hack

2017-07-03 Thread Eduardo Habkost
On Mon, Jul 03, 2017 at 09:38:52PM +0300, Michael S. Tsirkin wrote: > On Thu, Jun 29, 2017 at 03:23:04PM +0200, Marc-André Lureau wrote: > > This compat property sole function is to prevent the device from being > > instantiated. Instead of requiring an extra compat property, check if > > fw_cfg ha

Re: [Qemu-devel] [PATCH 1/7] vmgenid: replace x-write-pointer-available hack

2017-07-03 Thread Michael S. Tsirkin
On Thu, Jun 29, 2017 at 03:23:04PM +0200, Marc-André Lureau wrote: > This compat property sole function is to prevent the device from being > instantiated. Instead of requiring an extra compat property, check if > fw_cfg has DMA enabled. > > This has the additional benefit of handling other cases

Re: [Qemu-devel] [PATCH 1/7] vmgenid: replace x-write-pointer-available hack

2017-07-03 Thread Laszlo Ersek
On 07/03/17 20:27, Eduardo Habkost wrote: > On Mon, Jul 03, 2017 at 08:06:33PM +0200, Laszlo Ersek wrote: >> On 06/29/17 15:23, Marc-André Lureau wrote: >>> This compat property sole function is to prevent the device from being >>> instantiated. Instead of requiring an extra compat property, check

Re: [Qemu-devel] [PATCH 1/7] vmgenid: replace x-write-pointer-available hack

2017-07-03 Thread Eduardo Habkost
On Mon, Jul 03, 2017 at 08:06:33PM +0200, Laszlo Ersek wrote: > On 06/29/17 15:23, Marc-André Lureau wrote: > > This compat property sole function is to prevent the device from being > > instantiated. Instead of requiring an extra compat property, check if > > fw_cfg has DMA enabled. > > > > This

Re: [Qemu-devel] [PATCH 1/7] vmgenid: replace x-write-pointer-available hack

2017-07-03 Thread Michael S. Tsirkin
On Thu, Jun 29, 2017 at 03:23:04PM +0200, Marc-André Lureau wrote: > This compat property sole function is to prevent the device from being > instantiated. Instead of requiring an extra compat property, check if > fw_cfg has DMA enabled. > > This has the additional benefit of handling other cases

Re: [Qemu-devel] [PATCH 1/7] vmgenid: replace x-write-pointer-available hack

2017-07-03 Thread Laszlo Ersek
On 06/29/17 15:23, Marc-André Lureau wrote: > This compat property sole function is to prevent the device from being > instantiated. Instead of requiring an extra compat property, check if > fw_cfg has DMA enabled. > > This has the additional benefit of handling other cases properly, like: > >

Re: [Qemu-devel] [PATCH 1/7] vmgenid: replace x-write-pointer-available hack

2017-07-03 Thread Eduardo Habkost
On Thu, Jun 29, 2017 at 03:23:04PM +0200, Marc-André Lureau wrote: > This compat property sole function is to prevent the device from being > instantiated. Instead of requiring an extra compat property, check if > fw_cfg has DMA enabled. > > This has the additional benefit of handling other cases

Re: [Qemu-devel] [PATCH 1/7] vmgenid: replace x-write-pointer-available hack

2017-07-01 Thread Ben Warren via Qemu-devel
Nice improvement! > On Jun 29, 2017, at 9:23 AM, Marc-André Lureau > wrote: > > This compat property sole function is to prevent the device from being > instantiated. Instead of requiring an extra compat property, check if > fw_cfg has DMA enabled. > > This has the additional benefit of handlin

Re: [Qemu-devel] [PATCH 1/7] vmgenid: replace x-write-pointer-available hack

2017-06-29 Thread Michael S. Tsirkin
On Thu, Jun 29, 2017 at 03:23:04PM +0200, Marc-André Lureau wrote: > This compat property sole function is to prevent the device from being > instantiated. Instead of requiring an extra compat property, check if > fw_cfg has DMA enabled. > > This has the additional benefit of handling other cases

[Qemu-devel] [PATCH 1/7] vmgenid: replace x-write-pointer-available hack

2017-06-29 Thread Marc-André Lureau
This compat property sole function is to prevent the device from being instantiated. Instead of requiring an extra compat property, check if fw_cfg has DMA enabled. This has the additional benefit of handling other cases properly, like: $ qemu-system-x86_64 -device vmgenid -machine none qemu-