Re: [Qemu-devel] [PATCH 1/6] snapshot: export function in block.c

于 2013-1-8 18:37, Kevin Wolf 写道: > Am 08.01.2013 03:25, schrieb Wenchao Xia: >> 于 2013-1-8 0:43, Kevin Wolf 写道: >>> Am 17.12.2012 07:25, schrieb Wenchao Xia: This patch moves bdrv_snapshotfind from savevm.c to block.c and export it, also added bdrv_deappend in block.c. Signe

Re: [Qemu-devel] [PATCH 1/6] snapshot: export function in block.c

Am 08.01.2013 03:25, schrieb Wenchao Xia: > 于 2013-1-8 0:43, Kevin Wolf 写道: >> Am 17.12.2012 07:25, schrieb Wenchao Xia: >>>This patch moves bdrv_snapshotfind from savevm.c to block.c and export >>> it, also added bdrv_deappend in block.c. >>> >>> Signed-off-by: Wenchao Xia >> >> Should be two

Re: [Qemu-devel] [PATCH 1/6] snapshot: export function in block.c

于 2013-1-8 0:43, Kevin Wolf 写道: Am 17.12.2012 07:25, schrieb Wenchao Xia: This patch moves bdrv_snapshotfind from savevm.c to block.c and export it, also added bdrv_deappend in block.c. Signed-off-by: Wenchao Xia Should be two separate patches. OK, it have been split into two patches

Re: [Qemu-devel] [PATCH 1/6] snapshot: export function in block.c

Am 17.12.2012 07:25, schrieb Wenchao Xia: > This patch moves bdrv_snapshotfind from savevm.c to block.c and export > it, also added bdrv_deappend in block.c. > > Signed-off-by: Wenchao Xia Should be two separate patches. > --- > block.c | 30 ++ > block.h |

Re: [Qemu-devel] [PATCH 1/6] snapshot: export function in block.c

Thanks for reviewing carefully, this patch would be split to two patches. On Mon, Dec 17, 2012 at 02:25:04PM +0800, Wenchao Xia wrote: This patch moves bdrv_snapshotfind from savevm.c to block.c and export it, also added bdrv_deappend in block.c. I suggest naming the patch "block: export

Re: [Qemu-devel] [PATCH 1/6] snapshot: export function in block.c

On Mon, Dec 17, 2012 at 02:25:04PM +0800, Wenchao Xia wrote: > This patch moves bdrv_snapshotfind from savevm.c to block.c and export > it, also added bdrv_deappend in block.c. I suggest naming the patch "block: export bdrv_snapshot_find()" because it is more specific than "snapshot: export func

Re: [Qemu-devel] [PATCH 1/6] snapshot: export function in block.c

于 2012-12-22 2:13, Juan Quintela 写道: > Wenchao Xia wrote: >>This patch moves bdrv_snapshotfind from savevm.c to block.c and export >> it, also added bdrv_deappend in block.c. > > I think this patch can be splitted in two: > - new bdv_deappend > - move bdrv_snapshot_find > OK. -- Best Reg

Re: [Qemu-devel] [PATCH 1/6] snapshot: export function in block.c

Wenchao Xia wrote: > This patch moves bdrv_snapshotfind from savevm.c to block.c and export > it, also added bdrv_deappend in block.c. I think this patch can be splitted in two: - new bdv_deappend - move bdrv_snapshot_find

[Qemu-devel] [PATCH 1/6] snapshot: export function in block.c

This patch moves bdrv_snapshotfind from savevm.c to block.c and export it, also added bdrv_deappend in block.c. Signed-off-by: Wenchao Xia --- block.c | 30 ++ block.h |3 +++ savevm.c | 22 -- 3 files changed, 33 insertions(+), 22 dele