Re: [Qemu-devel] [PATCH 1/6] serial: make tsr_retry unsigned

2016-06-22 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > It can never become negative; reflect this in the type of the field > and simplify the conditions. OK, yes, the one case that could make it go -ve was removed in fcfb4d6 somewhere after 1.4.0. > Signed-off-by: Paolo Bonzini > --- > hw/char/serial.

[Qemu-devel] [PATCH 1/6] serial: make tsr_retry unsigned

2016-06-20 Thread Paolo Bonzini
It can never become negative; reflect this in the type of the field and simplify the conditions. Signed-off-by: Paolo Bonzini --- hw/char/serial.c | 12 include/hw/char/serial.h | 2 +- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/hw/char/serial.c b/hw/cha