Re: [Qemu-devel] [PATCH 1/6] pseries: Minor cleanups to HPT management hypercalls

2017-02-22 Thread Suraj Jitindar Singh
On Thu, 2017-02-23 at 13:09 +1100, David Gibson wrote: >  * Standardize on 'ptex' instead of 'pte_index' for HPTE index > variables >    for consistency and brevity >  * Avoid variables named 'index'; shadowing index(3) from libc can > lead to >    surprising bugs if the variable is removed, becaus

[Qemu-devel] [PATCH 1/6] pseries: Minor cleanups to HPT management hypercalls

2017-02-22 Thread David Gibson
* Standardize on 'ptex' instead of 'pte_index' for HPTE index variables for consistency and brevity * Avoid variables named 'index'; shadowing index(3) from libc can lead to surprising bugs if the variable is removed, because compiler errors might not appear for remaining references * C