Re: [Qemu-devel] [PATCH 1/6] PCI config space access overhaul

2010-01-12 Thread Michael S. Tsirkin
On Tue, Jan 12, 2010 at 11:36:58AM +0100, Alexander Graf wrote: > > On 05.01.2010, at 13:46, Isaku Yamahata wrote: > > > Basically it looks good. > > Some minor comments below. > > > > Although further clean up is possible, > > this is first small step. > > > > On Mon, Jan 04, 2010 at 08:32:50

Re: [Qemu-devel] [PATCH 1/6] PCI config space access overhaul

2010-01-12 Thread Alexander Graf
On 05.01.2010, at 13:46, Isaku Yamahata wrote: > Basically it looks good. > Some minor comments below. > > Although further clean up is possible, > this is first small step. > > On Mon, Jan 04, 2010 at 08:32:50AM +0100, Alexander Graf wrote: >> Different host buses may have different layouts f

Re: [Qemu-devel] [PATCH 1/6] PCI config space access overhaul

2010-01-05 Thread Isaku Yamahata
Basically it looks good. Some minor comments below. Although further clean up is possible, this is first small step. On Mon, Jan 04, 2010 at 08:32:50AM +0100, Alexander Graf wrote: > Different host buses may have different layouts for config space accessors. > > The Mac U3 for example uses the

Re: [Qemu-devel] [PATCH 1/6] PCI config space access overhaul

2010-01-05 Thread Michael S. Tsirkin
On Tue, Jan 05, 2010 at 09:46:38PM +0900, Isaku Yamahata wrote: > > diff --git a/hw/pci_host_template_all.h b/hw/pci_host_template_all.h > > new file mode 100644 > > index 000..74b3e84 > > --- /dev/null > > +++ b/hw/pci_host_template_all.h > > @@ -0,0 +1,23 @@ > > +#define PCI_HOST_BWLb > >

[Qemu-devel] [PATCH 1/6] PCI config space access overhaul

2010-01-03 Thread Alexander Graf
Different host buses may have different layouts for config space accessors. The Mac U3 for example uses the following define to access Type 0 (directly attached) devices: #define MACRISC_CFA0(devfn, off)\ ((1 << (unsigned int)PCI_SLOT(dev_fn)) \ | (((unsigned int)PCI_FUN