Re: [Qemu-devel] [PATCH 1/5] ide/atapi: make PIO read requests async

2015-10-16 Thread Peter Lieven
Am 14.10.2015 um 20:21 schrieb John Snow: > > On 10/14/2015 02:19 PM, Peter Lieven wrote: >> Am 08.10.2015 um 18:44 schrieb John Snow: >>> On 10/08/2015 08:06 AM, Peter Lieven wrote: Hi all, short summary from my side. The whole thing seems to get complicated, let me explain why

Re: [Qemu-devel] [PATCH 1/5] ide/atapi: make PIO read requests async

2015-10-14 Thread Peter Lieven
Am 08.10.2015 um 18:44 schrieb John Snow: > > On 10/08/2015 08:06 AM, Peter Lieven wrote: >> Hi all, >> >> short summary from my side. The whole thing seems to get complicated, >> let me explain why: >> >> 1) During review I found that the code in ide_atapi_cmd_reply_end can't >> work correctly if

Re: [Qemu-devel] [PATCH 1/5] ide/atapi: make PIO read requests async

2015-10-14 Thread John Snow
On 10/14/2015 02:19 PM, Peter Lieven wrote: > Am 08.10.2015 um 18:44 schrieb John Snow: >> >> On 10/08/2015 08:06 AM, Peter Lieven wrote: >>> Hi all, >>> >>> short summary from my side. The whole thing seems to get complicated, >>> let me explain why: >>> >>> 1) During review I found that the cod

Re: [Qemu-devel] [PATCH 1/5] ide/atapi: make PIO read requests async

2015-10-09 Thread Kevin Wolf
Am 08.10.2015 um 18:44 hat John Snow geschrieben: > On 10/08/2015 08:06 AM, Peter Lieven wrote: > > Hi all, > > > > short summary from my side. The whole thing seems to get complicated, > > let me explain why: > > > > 1) During review I found that the code in ide_atapi_cmd_reply_end can't > > wor

Re: [Qemu-devel] [PATCH 1/5] ide/atapi: make PIO read requests async

2015-10-09 Thread Peter Lieven
Am 09.10.2015 um 10:21 schrieb Kevin Wolf: > Am 08.10.2015 um 18:44 hat John Snow geschrieben: >> On 10/08/2015 08:06 AM, Peter Lieven wrote: >>> Hi all, >>> >>> short summary from my side. The whole thing seems to get complicated, >>> let me explain why: >>> >>> 1) During review I found that the c

Re: [Qemu-devel] [PATCH 1/5] ide/atapi: make PIO read requests async

2015-10-09 Thread John Snow
On 10/09/2015 04:21 AM, Kevin Wolf wrote: > Am 08.10.2015 um 18:44 hat John Snow geschrieben: >> On 10/08/2015 08:06 AM, Peter Lieven wrote: >>> Hi all, >>> >>> short summary from my side. The whole thing seems to get complicated, >>> let me explain why: >>> >>> 1) During review I found that the

Re: [Qemu-devel] [PATCH 1/5] ide/atapi: make PIO read requests async

2015-10-08 Thread John Snow
On 10/08/2015 08:06 AM, Peter Lieven wrote: > Hi all, > > short summary from my side. The whole thing seems to get complicated, > let me explain why: > > 1) During review I found that the code in ide_atapi_cmd_reply_end can't > work correctly if the > byte_count_limit is not a divider or a mult

Re: [Qemu-devel] [PATCH 1/5] ide/atapi: make PIO read requests async

2015-10-08 Thread Peter Lieven
Hi all, short summary from my side. The whole thing seems to get complicated, let me explain why: 1) During review I found that the code in ide_atapi_cmd_reply_end can't work correctly if the byte_count_limit is not a divider or a multiple of cd_sector_size. The reason is that as soon as we l

Re: [Qemu-devel] [PATCH 1/5] ide/atapi: make PIO read requests async

2015-10-07 Thread Peter Lieven
Am 07.10.2015 um 18:42 schrieb John Snow: > > On 10/06/2015 04:46 AM, Peter Lieven wrote: >> Am 05.10.2015 um 23:15 schrieb John Snow: >>> On 09/21/2015 08:25 AM, Peter Lieven wrote: PIO read requests on the ATAPI interface used to be sync blk requests. This has to siginificant drawbacks.

Re: [Qemu-devel] [PATCH 1/5] ide/atapi: make PIO read requests async

2015-10-07 Thread John Snow
On 10/06/2015 04:46 AM, Peter Lieven wrote: > Am 05.10.2015 um 23:15 schrieb John Snow: >> >> On 09/21/2015 08:25 AM, Peter Lieven wrote: >>> PIO read requests on the ATAPI interface used to be sync blk requests. >>> This has to siginificant drawbacks. First the main loop hangs util an >>> I/O re

Re: [Qemu-devel] [PATCH 1/5] ide/atapi: make PIO read requests async

2015-10-07 Thread Kevin Wolf
Am 06.10.2015 um 17:54 hat John Snow geschrieben: > > > On 10/06/2015 04:57 AM, Kevin Wolf wrote: > > Am 05.10.2015 um 23:15 hat John Snow geschrieben: > >> > >> > >> On 09/21/2015 08:25 AM, Peter Lieven wrote: > >>> PIO read requests on the ATAPI interface used to be sync blk requests. > >>> Thi

Re: [Qemu-devel] [PATCH 1/5] ide/atapi: make PIO read requests async

2015-10-06 Thread Peter Lieven
Am 06.10.2015 um 19:56 schrieb John Snow: > > On 10/06/2015 01:12 PM, Peter Lieven wrote: >>> Am 06.10.2015 um 19:07 schrieb John Snow : >>> >>> >>> On 10/06/2015 05:20 AM, Peter Lieven wrote: > Am 06.10.2015 um 10:57 schrieb Kevin Wolf: > Am 05.10.2015 um 23:15 hat John Snow geschrieb

Re: [Qemu-devel] [PATCH 1/5] ide/atapi: make PIO read requests async

2015-10-06 Thread Peter Lieven
> Am 06.10.2015 um 19:07 schrieb John Snow : > > > >> On 10/06/2015 05:20 AM, Peter Lieven wrote: >>> Am 06.10.2015 um 10:57 schrieb Kevin Wolf: >>> Am 05.10.2015 um 23:15 hat John Snow geschrieben: On 09/21/2015 08:25 AM, Peter Lieven wrote: > PIO read requests on the ATAPI inte

Re: [Qemu-devel] [PATCH 1/5] ide/atapi: make PIO read requests async

2015-10-06 Thread John Snow
On 10/06/2015 02:31 PM, Peter Lieven wrote: > Am 06.10.2015 um 19:56 schrieb John Snow: >> >> On 10/06/2015 01:12 PM, Peter Lieven wrote: Am 06.10.2015 um 19:07 schrieb John Snow : > On 10/06/2015 05:20 AM, Peter Lieven wrote: >> Am 06.10.2015 um 10:57 schrieb Kevin Wo

Re: [Qemu-devel] [PATCH 1/5] ide/atapi: make PIO read requests async

2015-10-06 Thread John Snow
On 10/06/2015 01:12 PM, Peter Lieven wrote: > >> Am 06.10.2015 um 19:07 schrieb John Snow : >> >> >> >>> On 10/06/2015 05:20 AM, Peter Lieven wrote: Am 06.10.2015 um 10:57 schrieb Kevin Wolf: Am 05.10.2015 um 23:15 hat John Snow geschrieben: > > On 09/21/2015 08:25 AM, Peter Li

Re: [Qemu-devel] [PATCH 1/5] ide/atapi: make PIO read requests async

2015-10-06 Thread John Snow
On 10/06/2015 05:20 AM, Peter Lieven wrote: > Am 06.10.2015 um 10:57 schrieb Kevin Wolf: >> Am 05.10.2015 um 23:15 hat John Snow geschrieben: >>> >>> On 09/21/2015 08:25 AM, Peter Lieven wrote: PIO read requests on the ATAPI interface used to be sync blk requests. This has to siginifica

Re: [Qemu-devel] [PATCH 1/5] ide/atapi: make PIO read requests async

2015-10-06 Thread John Snow
On 10/06/2015 04:57 AM, Kevin Wolf wrote: > Am 05.10.2015 um 23:15 hat John Snow geschrieben: >> >> >> On 09/21/2015 08:25 AM, Peter Lieven wrote: >>> PIO read requests on the ATAPI interface used to be sync blk requests. >>> This has to siginificant drawbacks. First the main loop hangs util an >

Re: [Qemu-devel] [PATCH 1/5] ide/atapi: make PIO read requests async

2015-10-06 Thread Laszlo Ersek
On 09/21/15 14:25, Peter Lieven wrote: > PIO read requests on the ATAPI interface used to be sync blk requests. > This has to siginificant drawbacks. First the main loop hangs util an Trivial comments: - s/to/two/ - s/siginificant/significant/ Thanks Laszlo > I/O request is completed and secondl

Re: [Qemu-devel] [PATCH 1/5] ide/atapi: make PIO read requests async

2015-10-06 Thread Peter Lieven
Am 06.10.2015 um 10:46 schrieb Peter Lieven: Am 05.10.2015 um 23:15 schrieb John Snow: On 09/21/2015 08:25 AM, Peter Lieven wrote: PIO read requests on the ATAPI interface used to be sync blk requests. This has to siginificant drawbacks. First the main loop hangs util an I/O request is complet

Re: [Qemu-devel] [PATCH 1/5] ide/atapi: make PIO read requests async

2015-10-06 Thread Peter Lieven
Am 06.10.2015 um 10:57 schrieb Kevin Wolf: Am 05.10.2015 um 23:15 hat John Snow geschrieben: On 09/21/2015 08:25 AM, Peter Lieven wrote: PIO read requests on the ATAPI interface used to be sync blk requests. This has to siginificant drawbacks. First the main loop hangs util an I/O request is c

Re: [Qemu-devel] [PATCH 1/5] ide/atapi: make PIO read requests async

2015-10-06 Thread Kevin Wolf
Am 05.10.2015 um 23:15 hat John Snow geschrieben: > > > On 09/21/2015 08:25 AM, Peter Lieven wrote: > > PIO read requests on the ATAPI interface used to be sync blk requests. > > This has to siginificant drawbacks. First the main loop hangs util an > > I/O request is completed and secondly if the

Re: [Qemu-devel] [PATCH 1/5] ide/atapi: make PIO read requests async

2015-10-06 Thread Peter Lieven
Am 05.10.2015 um 23:15 schrieb John Snow: On 09/21/2015 08:25 AM, Peter Lieven wrote: PIO read requests on the ATAPI interface used to be sync blk requests. This has to siginificant drawbacks. First the main loop hangs util an I/O request is completed and secondly if the I/O request does not co

Re: [Qemu-devel] [PATCH 1/5] ide/atapi: make PIO read requests async

2015-10-05 Thread John Snow
On 09/21/2015 08:25 AM, Peter Lieven wrote: > PIO read requests on the ATAPI interface used to be sync blk requests. > This has to siginificant drawbacks. First the main loop hangs util an > I/O request is completed and secondly if the I/O request does not > complete (e.g. due to an unresponsive

Re: [Qemu-devel] [PATCH 1/5] ide/atapi: make PIO read requests async

2015-10-02 Thread John Snow
On 09/21/2015 08:25 AM, Peter Lieven wrote: > PIO read requests on the ATAPI interface used to be sync blk requests. > This has to siginificant drawbacks. First the main loop hangs util an > I/O request is completed and secondly if the I/O request does not > complete (e.g. due to an unresponsive

[Qemu-devel] [PATCH 1/5] ide/atapi: make PIO read requests async

2015-09-21 Thread Peter Lieven
PIO read requests on the ATAPI interface used to be sync blk requests. This has to siginificant drawbacks. First the main loop hangs util an I/O request is completed and secondly if the I/O request does not complete (e.g. due to an unresponsive storage) Qemu hangs completely. Signed-off-by: Peter