Re: [Qemu-devel] [PATCH 1/5] block: Auto-generate node_names for each BDS entry

2014-05-16 Thread Kevin Wolf
Am 16.05.2014 um 14:47 hat Eric Blake geschrieben: > On 05/16/2014 05:35 AM, Jeff Cody wrote: > > > > > How does libvirt assign node-names to all the backing images in a > > qcow2 chain, for example? > > We have the ability to do both command-line and QMP hotplug addition of > drives where you c

Re: [Qemu-devel] [PATCH 1/5] block: Auto-generate node_names for each BDS entry

2014-05-16 Thread Eric Blake
On 05/16/2014 05:35 AM, Jeff Cody wrote: > > How does libvirt assign node-names to all the backing images in a > qcow2 chain, for example? We have the ability to do both command-line and QMP hotplug addition of drives where you can set backing.file.node-name (or is it backing.node-name?) for any

Re: [Qemu-devel] [PATCH 1/5] block: Auto-generate node_names for each BDS entry

2014-05-16 Thread Jeff Cody
On Fri, May 16, 2014 at 11:39:27AM +0200, Kevin Wolf wrote: > Am 15.05.2014 um 20:41 hat Jeff Cody geschrieben: > > The only thing I don't like about moving this further back in the > > patch series is it makes the earlier patches untestable; I can't > > easily test the usage of the node-names for

Re: [Qemu-devel] [PATCH 1/5] block: Auto-generate node_names for each BDS entry

2014-05-16 Thread Kevin Wolf
Am 15.05.2014 um 20:41 hat Jeff Cody geschrieben: > The only thing I don't like about moving this further back in the > patch series is it makes the earlier patches untestable; I can't > easily test the usage of the node-names for various intermediate BDS > because they don't have node-names set.

Re: [Qemu-devel] [PATCH 1/5] block: Auto-generate node_names for each BDS entry

2014-05-15 Thread Eric Blake
On 05/15/2014 12:41 PM, Jeff Cody wrote: >>> The prefix is to aid in identifying it as a qemu-generated name, the >>> numeric portion is to guarantee uniqueness in a given qemu session, and >>> the random characters are to further avoid any accidental collisions >>> with user-specified node-names.

Re: [Qemu-devel] [PATCH 1/5] block: Auto-generate node_names for each BDS entry

2014-05-15 Thread Jeff Cody
On Thu, May 15, 2014 at 09:59:01AM -0600, Eric Blake wrote: > On 05/14/2014 09:20 PM, Jeff Cody wrote: > > Currently, node_name is only filled in when done so explicitly by the > > user. If no node_name is specified, then the node name field is not > > populated. > > > > If node_names are automat

Re: [Qemu-devel] [PATCH 1/5] block: Auto-generate node_names for each BDS entry

2014-05-15 Thread Eric Blake
On 05/14/2014 09:20 PM, Jeff Cody wrote: > Currently, node_name is only filled in when done so explicitly by the > user. If no node_name is specified, then the node name field is not > populated. > > If node_names are automatically generated when not specified, that means > that all block job ope

Re: [Qemu-devel] [PATCH 1/5] block: Auto-generate node_names for each BDS entry

2014-05-15 Thread Eric Blake
On 05/14/2014 09:20 PM, Jeff Cody wrote: > Currently, node_name is only filled in when done so explicitly by the > user. If no node_name is specified, then the node name field is not > populated. > > If node_names are automatically generated when not specified, that means > that all block job ope

Re: [Qemu-devel] [PATCH 1/5] block: Auto-generate node_names for each BDS entry

2014-05-15 Thread Jeff Cody
On Thu, May 15, 2014 at 02:32:50PM +0200, Benoît Canet wrote: > The Thursday 15 May 2014 à 08:06:14 (-0400), Jeff Cody wrote : > > On Thu, May 15, 2014 at 01:58:59PM +0200, Benoît Canet wrote: > > > The Wednesday 14 May 2014 à 23:20:15 (-0400), Jeff Cody wrote : > > > > Currently, node_name is only

Re: [Qemu-devel] [PATCH 1/5] block: Auto-generate node_names for each BDS entry

2014-05-15 Thread Benoît Canet
The Thursday 15 May 2014 à 08:06:14 (-0400), Jeff Cody wrote : > On Thu, May 15, 2014 at 01:58:59PM +0200, Benoît Canet wrote: > > The Wednesday 14 May 2014 à 23:20:15 (-0400), Jeff Cody wrote : > > > Currently, node_name is only filled in when done so explicitly by the > > > user. If no node_name

Re: [Qemu-devel] [PATCH 1/5] block: Auto-generate node_names for each BDS entry

2014-05-15 Thread Jeff Cody
On Thu, May 15, 2014 at 01:58:59PM +0200, Benoît Canet wrote: > The Wednesday 14 May 2014 à 23:20:15 (-0400), Jeff Cody wrote : > > Currently, node_name is only filled in when done so explicitly by the > > user. If no node_name is specified, then the node name field is not > > populated. > > > >

Re: [Qemu-devel] [PATCH 1/5] block: Auto-generate node_names for each BDS entry

2014-05-15 Thread Benoît Canet
The Wednesday 14 May 2014 à 23:20:15 (-0400), Jeff Cody wrote : > Currently, node_name is only filled in when done so explicitly by the > user. If no node_name is specified, then the node name field is not > populated. > > If node_names are automatically generated when not specified, that means >

[Qemu-devel] [PATCH 1/5] block: Auto-generate node_names for each BDS entry

2014-05-14 Thread Jeff Cody
Currently, node_name is only filled in when done so explicitly by the user. If no node_name is specified, then the node name field is not populated. If node_names are automatically generated when not specified, that means that all block job operations can be done by reference to the unique node_n