Re: [Qemu-devel] [PATCH 1/4] vga: move bochs vbe defines to header file

2018-05-22 Thread Gerd Hoffmann
> > --- /dev/null > > +++ b/include/hw/display/bochs-vbe.h > > @@ -0,0 +1,64 @@ > > No header guards & copyright notice? Header guards ok. Copyright? I don't think interface #defines like this are copyrightable ... cheers, Gerd

Re: [Qemu-devel] [PATCH 1/4] vga: move bochs vbe defines to header file

2018-05-18 Thread Marc-André Lureau
Hi On Thu, May 17, 2018 at 11:25 AM, Gerd Hoffmann wrote: > Create a new header file, move the bochs vbe dispi interface > defines to it, so they can be used outside vga code. > > Signed-off-by: Gerd Hoffmann > --- > hw/display/vga_int.h | 35 ++- > include/hw/disp

Re: [Qemu-devel] [PATCH 1/4] vga: move bochs vbe defines to header file

2018-05-18 Thread Gerd Hoffmann
On Thu, May 17, 2018 at 12:20:58PM -0300, Philippe Mathieu-Daudé wrote: > On 05/17/2018 06:25 AM, Gerd Hoffmann wrote: > > Create a new header file, move the bochs vbe dispi interface > > defines to it, so they can be used outside vga code. > > > > Signed-off-by: Gerd Hoffmann > > --- > > hw/dis

Re: [Qemu-devel] [PATCH 1/4] vga: move bochs vbe defines to header file

2018-05-17 Thread Philippe Mathieu-Daudé
On 05/17/2018 06:25 AM, Gerd Hoffmann wrote: > Create a new header file, move the bochs vbe dispi interface > defines to it, so they can be used outside vga code. > > Signed-off-by: Gerd Hoffmann > --- > hw/display/vga_int.h | 35 ++- > include/hw/display/bochs-vbe.

[Qemu-devel] [PATCH 1/4] vga: move bochs vbe defines to header file

2018-05-17 Thread Gerd Hoffmann
Create a new header file, move the bochs vbe dispi interface defines to it, so they can be used outside vga code. Signed-off-by: Gerd Hoffmann --- hw/display/vga_int.h | 35 ++- include/hw/display/bochs-vbe.h | 64 ++ hw/displ