Re: [Qemu-devel] [PATCH 1/4] target/arm: Split out recompute_hflags et al

2019-02-19 Thread Richard Henderson
On 2/19/19 3:06 AM, Alex Bennée wrote: >> +/* FIXME: ARMv8.1-VHE S2 translation regime. */ > This is technically a TODO isn't it? > Yeah, sure, but we aren't good about that categorization. And anyway this is code movement. r~

Re: [Qemu-devel] [PATCH 1/4] target/arm: Split out recompute_hflags et al

2019-02-19 Thread Alex Bennée
Richard Henderson writes: > We will use these to minimize the computation for every call to > cpu_get_tb_cpu_state. For now, the env->hflags variable is not used. > > Signed-off-by: Richard Henderson > --- > target/arm/cpu.h | 22 +++- > target/arm/helper.h| 3 + > target/arm/in

[Qemu-devel] [PATCH 1/4] target/arm: Split out recompute_hflags et al

2019-02-13 Thread Richard Henderson
We will use these to minimize the computation for every call to cpu_get_tb_cpu_state. For now, the env->hflags variable is not used. Signed-off-by: Richard Henderson --- target/arm/cpu.h | 22 +++- target/arm/helper.h| 3 + target/arm/internals.h | 3 + target/arm/helper.c| 2