Re: [Qemu-devel] [PATCH 1/4] s390x/pci: fixup trap_msix()

2017-08-30 Thread Cornelia Huck
On Mon, 28 Aug 2017 10:04:44 +0200 Yi Min Zhao wrote: > The function trap_msix() is to check if pcistg instruction would access > msix table entries. The correct boundary condition should be > [table_offset, table_offset+entries*entry_size). But the current > condition calculated misses the last

Re: [Qemu-devel] [PATCH 1/4] s390x/pci: fixup trap_msix()

2017-08-29 Thread Cornelia Huck
On Tue, 29 Aug 2017 16:33:52 +0800 Yi Min Zhao wrote: > 在 2017/8/29 下午4:22, Cornelia Huck 写道: > > On Tue, 29 Aug 2017 16:12:26 +0800 > > Yi Min Zhao wrote: > > > >> 在 2017/8/29 下午4:00, Cornelia Huck 写道: > >>> On Tue, 29 Aug 2017 12:32:17 +0800 > >>> Yi Min Zhao wrote: > >>> > 在 20

Re: [Qemu-devel] [PATCH 1/4] s390x/pci: fixup trap_msix()

2017-08-29 Thread Yi Min Zhao
在 2017/8/29 下午4:22, Cornelia Huck 写道: On Tue, 29 Aug 2017 16:12:26 +0800 Yi Min Zhao wrote: 在 2017/8/29 下午4:00, Cornelia Huck 写道: On Tue, 29 Aug 2017 12:32:17 +0800 Yi Min Zhao wrote: 在 2017/8/28 下午10:51, Cornelia Huck 写道: On Mon, 28 Aug 2017 10:04:44 +0200 Yi Min Zhao wrote:

Re: [Qemu-devel] [PATCH 1/4] s390x/pci: fixup trap_msix()

2017-08-29 Thread Cornelia Huck
On Tue, 29 Aug 2017 16:12:26 +0800 Yi Min Zhao wrote: > 在 2017/8/29 下午4:00, Cornelia Huck 写道: > > On Tue, 29 Aug 2017 12:32:17 +0800 > > Yi Min Zhao wrote: > > > >> 在 2017/8/28 下午10:51, Cornelia Huck 写道: > >>> On Mon, 28 Aug 2017 10:04:44 +0200 > >>> Yi Min Zhao wrote: > >>> > The

Re: [Qemu-devel] [PATCH 1/4] s390x/pci: fixup trap_msix()

2017-08-29 Thread Yi Min Zhao
在 2017/8/29 下午4:00, Cornelia Huck 写道: On Tue, 29 Aug 2017 12:32:17 +0800 Yi Min Zhao wrote: 在 2017/8/28 下午10:51, Cornelia Huck 写道: On Mon, 28 Aug 2017 10:04:44 +0200 Yi Min Zhao wrote: The function trap_msix() is to check if pcistg instruction would access msix table entries. The corre

Re: [Qemu-devel] [PATCH 1/4] s390x/pci: fixup trap_msix()

2017-08-29 Thread Yi Min Zhao
在 2017/8/29 下午4:00, Cornelia Huck 写道: On Tue, 29 Aug 2017 12:32:17 +0800 Yi Min Zhao wrote: 在 2017/8/28 下午10:51, Cornelia Huck 写道: On Mon, 28 Aug 2017 10:04:44 +0200 Yi Min Zhao wrote: The function trap_msix() is to check if pcistg instruction would access msix table entries. The corre

Re: [Qemu-devel] [PATCH 1/4] s390x/pci: fixup trap_msix()

2017-08-29 Thread Cornelia Huck
On Tue, 29 Aug 2017 12:32:17 +0800 Yi Min Zhao wrote: > 在 2017/8/28 下午10:51, Cornelia Huck 写道: > > On Mon, 28 Aug 2017 10:04:44 +0200 > > Yi Min Zhao wrote: > > > >> The function trap_msix() is to check if pcistg instruction would access > >> msix table entries. The correct boundary condition

Re: [Qemu-devel] [PATCH 1/4] s390x/pci: fixup trap_msix()

2017-08-28 Thread Yi Min Zhao
在 2017/8/28 下午10:51, Cornelia Huck 写道: On Mon, 28 Aug 2017 10:04:44 +0200 Yi Min Zhao wrote: The function trap_msix() is to check if pcistg instruction would access msix table entries. The correct boundary condition should be [table_offset, table_offset+entries*entry_size). But the current c

Re: [Qemu-devel] [PATCH 1/4] s390x/pci: fixup trap_msix()

2017-08-28 Thread Cornelia Huck
On Mon, 28 Aug 2017 10:04:44 +0200 Yi Min Zhao wrote: > The function trap_msix() is to check if pcistg instruction would access > msix table entries. The correct boundary condition should be > [table_offset, table_offset+entries*entry_size). But the current > condition calculated misses the last

[Qemu-devel] [PATCH 1/4] s390x/pci: fixup trap_msix()

2017-08-28 Thread Yi Min Zhao
The function trap_msix() is to check if pcistg instruction would access msix table entries. The correct boundary condition should be [table_offset, table_offset+entries*entry_size). But the current condition calculated misses the last entry. So let's fixup it. Acked-by: Dong Jia Shi Reviewed-by: