Re: [Qemu-devel] [PATCH 1/4] qapi: Use Python 2.6 "except E as ..." syntax

2015-12-17 Thread Peter Maydell
On 17 December 2015 at 10:06, Markus Armbruster wrote: > PEP 8 calls for it, because it's forward compatibile with Python 3. Typo nit: "compatible". thanks -- PMM

Re: [Qemu-devel] [PATCH 1/4] qapi: Use Python 2.6 "except E as ..." syntax

2015-12-17 Thread Eric Blake
On 12/17/2015 11:35 AM, Markus Armbruster wrote: > Eric Blake writes: > >> On 12/17/2015 03:06 AM, Markus Armbruster wrote: >>> PEP 8 calls for it, because it's forward compatibile with Python 3. >> >> And possible as a cleanup only because we require 2.6 as a minimum since >> fec21036 (your subj

Re: [Qemu-devel] [PATCH 1/4] qapi: Use Python 2.6 "except E as ..." syntax

2015-12-17 Thread Markus Armbruster
Eric Blake writes: > On 12/17/2015 03:06 AM, Markus Armbruster wrote: >> PEP 8 calls for it, because it's forward compatibile with Python 3. > > And possible as a cleanup only because we require 2.6 as a minimum since > fec21036 (your subject line hints at it, even if not stating it outright). W

Re: [Qemu-devel] [PATCH 1/4] qapi: Use Python 2.6 "except E as ..." syntax

2015-12-17 Thread Eric Blake
On 12/17/2015 03:06 AM, Markus Armbruster wrote: > PEP 8 calls for it, because it's forward compatibile with Python 3. And possible as a cleanup only because we require 2.6 as a minimum since fec21036 (your subject line hints at it, even if not stating it outright). > > Signed-off-by: Markus Arm

[Qemu-devel] [PATCH 1/4] qapi: Use Python 2.6 "except E as ..." syntax

2015-12-17 Thread Markus Armbruster
PEP 8 calls for it, because it's forward compatibile with Python 3. Signed-off-by: Markus Armbruster --- scripts/qapi.py | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/scripts/qapi.py b/scripts/qapi.py index 7c50cc4..ba7151b 100644 --- a/scripts/qapi.py +++ b/scripts