Re: [Qemu-devel] [PATCH 1/3] vnc: remove superfluous vnc_display_close()

2014-10-23 Thread Gonglei
On 2014/10/23 15:09, Michael Tokarev wrote: > On 10/23/2014 09:39 AM, arei.gong...@huawei.com wrote: >> From: Gonglei >> >> vnc_display_close() is called in vnc_display_open(). >> And in this moment, the ds variable is initilized >> at vnc_display_init(). Calling vnc_display_close() >> is superfl

Re: [Qemu-devel] [PATCH 1/3] vnc: remove superfluous vnc_display_close()

2014-10-23 Thread Michael Tokarev
On 10/23/2014 09:39 AM, arei.gong...@huawei.com wrote: > From: Gonglei > > vnc_display_close() is called in vnc_display_open(). > And in this moment, the ds variable is initilized > at vnc_display_init(). Calling vnc_display_close() > is superfluous. Maybe the intent was to be able to open/close

[Qemu-devel] [PATCH 1/3] vnc: remove superfluous vnc_display_close()

2014-10-22 Thread arei.gonglei
From: Gonglei vnc_display_close() is called in vnc_display_open(). And in this moment, the ds variable is initilized at vnc_display_init(). Calling vnc_display_close() is superfluous. For another scenario, qmp_change_vnc_listen() pass NULL into vnc_display_open(), which is not influenced too. L