Re: [Qemu-devel] [PATCH 1/3] vmstate: add no_migrate flag to VMStateDescription

2011-07-10 Thread Gerd Hoffmann
register_device_unmigratable()? Right, but can we have some continuity at least between the two interfaces? At least make the vmstate flag 'unmigratable' or rename the function to qdev_set_no_migrate(). Will rename the flag. BTW, should this be a vmstate flag or a qdev flag? vmstate. sa

Re: [Qemu-devel] [PATCH 1/3] vmstate: add no_migrate flag to VMStateDescription

2011-07-08 Thread Anthony Liguori
On 07/08/2011 11:04 AM, Gerd Hoffmann wrote: On 07/08/11 17:44, Gerd Hoffmann wrote: On 07/08/11 16:26, Anthony Liguori wrote: register_device_unmigratable()? Wanna have a patch to zap it? Ah, no, we can't, for ivshmem this isn't fixed but depends on the configuration, so a static flag in t

Re: [Qemu-devel] [PATCH 1/3] vmstate: add no_migrate flag to VMStateDescription

2011-07-08 Thread Gerd Hoffmann
On 07/08/11 17:44, Gerd Hoffmann wrote: On 07/08/11 16:26, Anthony Liguori wrote: register_device_unmigratable()? Wanna have a patch to zap it? Ah, no, we can't, for ivshmem this isn't fixed but depends on the configuration, so a static flag in the VMStateDescription doesn't cut it. cheer

Re: [Qemu-devel] [PATCH 1/3] vmstate: add no_migrate flag to VMStateDescription

2011-07-08 Thread Gerd Hoffmann
On 07/08/11 16:26, Anthony Liguori wrote: On 07/08/2011 03:53 AM, Gerd Hoffmann wrote: This allows to easily tag devices as non-migratable, so any attempt to migrate a virtual machine with the device in question active will make migration fail. Signed-off-by: Gerd Hoffmann register_device_unm

Re: [Qemu-devel] [PATCH 1/3] vmstate: add no_migrate flag to VMStateDescription

2011-07-08 Thread Anthony Liguori
On 07/08/2011 03:53 AM, Gerd Hoffmann wrote: This allows to easily tag devices as non-migratable, so any attempt to migrate a virtual machine with the device in question active will make migration fail. Signed-off-by: Gerd Hoffmann register_device_unmigratable()? Regards, Anthony Liguori -

[Qemu-devel] [PATCH 1/3] vmstate: add no_migrate flag to VMStateDescription

2011-07-08 Thread Gerd Hoffmann
This allows to easily tag devices as non-migratable, so any attempt to migrate a virtual machine with the device in question active will make migration fail. Signed-off-by: Gerd Hoffmann --- hw/hw.h |1 + savevm.c |1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/h