Re: [Qemu-devel] [PATCH 1/3] virtio_balloon: Remove unnecessarily persistent state

2012-04-12 Thread Michael S. Tsirkin
On Thu, Apr 12, 2012 at 03:36:33PM +1000, David Gibson wrote: > The main virtio_balloon state structure contains the fields num_pfns and > array 'pfns'. Although they are stored here persistently, the lifetime of > useful data in there is never more than one function - they're essentially > used a

Re: [Qemu-devel] [PATCH 1/3] virtio_balloon: Remove unnecessarily persistent state

2012-04-12 Thread Michael S. Tsirkin
On Thu, Apr 12, 2012 at 03:36:33PM +1000, David Gibson wrote: > The main virtio_balloon state structure contains the fields num_pfns and > array 'pfns'. Although they are stored here persistently, the lifetime of > useful data in there is never more than one function - they're essentially > used a

[Qemu-devel] [PATCH 1/3] virtio_balloon: Remove unnecessarily persistent state

2012-04-11 Thread David Gibson
The main virtio_balloon state structure contains the fields num_pfns and array 'pfns'. Although they are stored here persistently, the lifetime of useful data in there is never more than one function - they're essentially used as though they were local variables. For the pfns buffer, used to comm