Re: [Qemu-devel] [PATCH 1/3] virtio-balloon: discard virtqueue element on reset

2016-09-08 Thread Roman Kagan
On Wed, Sep 07, 2016 at 05:20:47PM +0200, Ladi Prosek wrote: > The one pending element is being freed but not discarded on device > reset, which causes svq->inuse to creep up, eventually hitting the > "Virtqueue size exceeded" error. > > Properly discarding the element on device reset makes sure t

Re: [Qemu-devel] [PATCH 1/3] virtio-balloon: discard virtqueue element on reset

2016-09-07 Thread Stefan Hajnoczi
On Wed, Sep 07, 2016 at 05:20:47PM +0200, Ladi Prosek wrote: > The one pending element is being freed but not discarded on device > reset, which causes svq->inuse to creep up, eventually hitting the > "Virtqueue size exceeded" error. > > Properly discarding the element on device reset makes sure t

[Qemu-devel] [PATCH 1/3] virtio-balloon: discard virtqueue element on reset

2016-09-07 Thread Ladi Prosek
The one pending element is being freed but not discarded on device reset, which causes svq->inuse to creep up, eventually hitting the "Virtqueue size exceeded" error. Properly discarding the element on device reset makes sure that its buffers are unmapped and the inuse counter stays balanced. Cc: