Re: [Qemu-devel] [PATCH 1/3] virtio: move cross-endian helper to vhost

2015-11-13 Thread Greg Kurz
On Thu, 12 Nov 2015 19:00:54 +0100 Cornelia Huck wrote: > On Mon, 09 Nov 2015 18:58:16 +0100 > Greg Kurz wrote: > > > If target is bi-endian (ppc64, arm), the virtio_legacy_is_cross_endian() > > indeed returns the runtime state of the virtio device. However, it returns > > false unconditionally

Re: [Qemu-devel] [PATCH 1/3] virtio: move cross-endian helper to vhost

2015-11-12 Thread Cornelia Huck
On Mon, 09 Nov 2015 18:58:16 +0100 Greg Kurz wrote: > If target is bi-endian (ppc64, arm), the virtio_legacy_is_cross_endian() > indeed returns the runtime state of the virtio device. However, it returns > false unconditionally in the general case. This sounds a bit strange > given the name of th

[Qemu-devel] [PATCH 1/3] virtio: move cross-endian helper to vhost

2015-11-09 Thread Greg Kurz
If target is bi-endian (ppc64, arm), the virtio_legacy_is_cross_endian() indeed returns the runtime state of the virtio device. However, it returns false unconditionally in the general case. This sounds a bit strange given the name of the function. This helper is only useful for vhost actually, wh