Re: [Qemu-devel] [PATCH 1/3] virtio: introduce grab/release_ioeventfd to fix vhost

2016-11-18 Thread Michael S. Tsirkin
On Fri, Nov 18, 2016 at 09:15:32AM +0100, Christian Borntraeger wrote: > On 11/16/2016 07:05 PM, Paolo Bonzini wrote: > > Following the recent refactoring of virtio notifiers [1], more specifically > > the patch ed08a2a0b ("virtio: use virtio_bus_set_host_notifier to > > start/stop ioeventfd") that

Re: [Qemu-devel] [PATCH 1/3] virtio: introduce grab/release_ioeventfd to fix vhost

2016-11-18 Thread Christian Borntraeger
On 11/16/2016 07:05 PM, Paolo Bonzini wrote: > Following the recent refactoring of virtio notifiers [1], more specifically > the patch ed08a2a0b ("virtio: use virtio_bus_set_host_notifier to > start/stop ioeventfd") that uses virtio_bus_set_host_notifier [2] > by default, core virtio code requires

Re: [Qemu-devel] [PATCH 1/3] virtio: introduce grab/release_ioeventfd to fix vhost

2016-11-17 Thread Cornelia Huck
On Wed, 16 Nov 2016 19:05:49 +0100 Paolo Bonzini wrote: > Following the recent refactoring of virtio notifiers [1], more specifically > the patch ed08a2a0b ("virtio: use virtio_bus_set_host_notifier to > start/stop ioeventfd") that uses virtio_bus_set_host_notifier [2] > by default, core virtio c

Re: [Qemu-devel] [PATCH 1/3] virtio: introduce grab/release_ioeventfd to fix vhost

2016-11-16 Thread Alexey Kardashevskiy
On 17/11/16 05:05, Paolo Bonzini wrote: > Following the recent refactoring of virtio notifiers [1], more specifically > the patch ed08a2a0b ("virtio: use virtio_bus_set_host_notifier to > start/stop ioeventfd") that uses virtio_bus_set_host_notifier [2] > by default, core virtio code requires 'ioev

[Qemu-devel] [PATCH 1/3] virtio: introduce grab/release_ioeventfd to fix vhost

2016-11-16 Thread Paolo Bonzini
Following the recent refactoring of virtio notifiers [1], more specifically the patch ed08a2a0b ("virtio: use virtio_bus_set_host_notifier to start/stop ioeventfd") that uses virtio_bus_set_host_notifier [2] by default, core virtio code requires 'ioeventfd_started' to be set to true/false when the

Re: [Qemu-devel] [PATCH 1/3] virtio: introduce grab/release_ioeventfd to fix vhost

2016-11-15 Thread Paolo Bonzini
On 15/11/2016 16:32, Cornelia Huck wrote: > This basically looks sane to me, but it is really hard to wrap one's > brain around this, so maybe this needs more comments? (I have added > some suggestions.) Very good - I'll include them in v2. Paolo

Re: [Qemu-devel] [PATCH 1/3] virtio: introduce grab/release_ioeventfd to fix vhost

2016-11-15 Thread Cornelia Huck
On Tue, 15 Nov 2016 14:46:27 +0100 Paolo Bonzini wrote: > Following the recent refactoring of virtio notifiers [1], more specifically > the patch ed08a2a0b ("virtio: use virtio_bus_set_host_notifier to > start/stop ioeventfd") that uses virtio_bus_set_host_notifier [2] > by default, core virtio c

[Qemu-devel] [PATCH 1/3] virtio: introduce grab/release_ioeventfd to fix vhost

2016-11-15 Thread Paolo Bonzini
Following the recent refactoring of virtio notifiers [1], more specifically the patch ed08a2a0b ("virtio: use virtio_bus_set_host_notifier to start/stop ioeventfd") that uses virtio_bus_set_host_notifier [2] by default, core virtio code requires 'ioeventfd_started' to be set to true/false when the