Re: [Qemu-devel] [PATCH 1/3] tcg: Mask shift quantities while folding

2014-03-18 Thread Richard Henderson
On 03/18/2014 08:59 AM, Peter Maydell wrote: > Don't you also need to do something similar for the > "calculate known-zeroes bits" code on lines 807..833 ? Yep. r~

Re: [Qemu-devel] [PATCH 1/3] tcg: Mask shift quantities while folding

2014-03-18 Thread Peter Maydell
On 18 March 2014 15:48, Richard Henderson wrote: > The TCG result would be undefined, but we can at least produce one > plausible result and avoid triggering the wrath of analysis tools. > > Reported-by: Peter Maydell > Signed-off-by: Richard Henderson Don't you also need to do something simila

[Qemu-devel] [PATCH 1/3] tcg: Mask shift quantities while folding

2014-03-18 Thread Richard Henderson
The TCG result would be undefined, but we can at least produce one plausible result and avoid triggering the wrath of analysis tools. Reported-by: Peter Maydell Signed-off-by: Richard Henderson --- tcg/optimize.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff