Re: [Qemu-devel] [PATCH 1/3] target-i386: add EXT2_PPRO_FEATURES #define

2012-12-14 Thread Eduardo Habkost
On Fri, Dec 14, 2012 at 12:44:43PM +0100, Andreas Färber wrote: > Am 12.12.2012 23:22, schrieb Eduardo Habkost: > > Instead of repeating the (PPRO_FEATURES & CPUID_EXT2_AMD_ALIASES) > > expression everywhere, use EXT2_PPRO_FEATURES. > > > > Signed-off-by: Eduardo Habkost > > Technically this pat

Re: [Qemu-devel] [PATCH 1/3] target-i386: add EXT2_PPRO_FEATURES #define

2012-12-14 Thread Andreas Färber
Am 12.12.2012 23:22, schrieb Eduardo Habkost: > Instead of repeating the (PPRO_FEATURES & CPUID_EXT2_AMD_ALIASES) > expression everywhere, use EXT2_PPRO_FEATURES. > > Signed-off-by: Eduardo Habkost Technically this patch looks fine. My dislike for these defines aside, I have doubts about the sem

Re: [Qemu-devel] [PATCH 1/3] target-i386: add EXT2_PPRO_FEATURES #define

2012-12-14 Thread Igor Mammedov
On Wed, 12 Dec 2012 20:22:24 -0200 Eduardo Habkost wrote: > Instead of repeating the (PPRO_FEATURES & CPUID_EXT2_AMD_ALIASES) > expression everywhere, use EXT2_PPRO_FEATURES. > > Signed-off-by: Eduardo Habkost > --- > target-i386/cpu.c | 13 +++-- > 1 file changed, 7 insertions(+), 6 d

[Qemu-devel] [PATCH 1/3] target-i386: add EXT2_PPRO_FEATURES #define

2012-12-12 Thread Eduardo Habkost
Instead of repeating the (PPRO_FEATURES & CPUID_EXT2_AMD_ALIASES) expression everywhere, use EXT2_PPRO_FEATURES. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 546c