Re: [Qemu-devel] [PATCH 1/3] s390x/css: unrestrict cssids

2017-12-04 Thread Dong Jia Shi
* Halil Pasic [2017-12-01 15:31:34 +0100]: [...] No comment for the message part. The code looks good to me. So after squashing with patch #2: Reviewed-by: Dong Jia Shi > --- > hw/s390x/3270-ccw.c| 2 +- > hw/s390x/css.c | 28 > hw/s390x/s390

Re: [Qemu-devel] [PATCH 1/3] s390x/css: unrestrict cssids

2017-12-04 Thread Cornelia Huck
On Mon, 4 Dec 2017 16:02:14 +0100 Halil Pasic wrote: > On 12/04/2017 12:10 PM, Cornelia Huck wrote: > > On Fri, 1 Dec 2017 15:31:34 +0100 > > Halil Pasic wrote: > > > >> The default css 0xfe is currently restricted to virtual subchannel > >> devices. The hope when the decision was made was,

Re: [Qemu-devel] [PATCH 1/3] s390x/css: unrestrict cssids

2017-12-04 Thread Halil Pasic
On 12/04/2017 12:10 PM, Cornelia Huck wrote: > On Fri, 1 Dec 2017 15:31:34 +0100 > Halil Pasic wrote: > >> The default css 0xfe is currently restricted to virtual subchannel >> devices. The hope when the decision was made was, that non-virtual >> subchannel devices will come around when guests

Re: [Qemu-devel] [PATCH 1/3] s390x/css: unrestrict cssids

2017-12-04 Thread Christian Borntraeger
On 12/04/2017 12:10 PM, Cornelia Huck wrote: [..] > >> >> Signed-off-by: Halil Pasic squashed or non-squashed: Acked-by: Christian Borntraeger

Re: [Qemu-devel] [PATCH 1/3] s390x/css: unrestrict cssids

2017-12-04 Thread Cornelia Huck
On Fri, 1 Dec 2017 15:31:34 +0100 Halil Pasic wrote: > The default css 0xfe is currently restricted to virtual subchannel > devices. The hope when the decision was made was, that non-virtual > subchannel devices will come around when guests can exploit multiple > channel subsystems. Since curren

[Qemu-devel] [PATCH 1/3] s390x/css: unrestrict cssids

2017-12-01 Thread Halil Pasic
The default css 0xfe is currently restricted to virtual subchannel devices. The hope when the decision was made was, that non-virtual subchannel devices will come around when guests can exploit multiple channel subsystems. Since current guests don't do that, the pain of the partitioned (cssid) name