Re: [Qemu-devel] [PATCH 1/3] qtest: Enable creation of multiple qemu instances

2012-12-19 Thread Blue Swirl
On Mon, Dec 17, 2012 at 5:13 PM, Jason Baron wrote: > On Sat, Dec 15, 2012 at 09:20:13AM +, Blue Swirl wrote: >> On Sat, Dec 15, 2012 at 9:14 AM, Paolo Bonzini wrote: >> >> > +#define QTEST_FILE_TEMP "/tmp/qtest-%d.sock" >> >> > +#define QTEST_QMP_FILE_TEMP "/tmp/qtest-%d.qmp" >> >> > +#defin

Re: [Qemu-devel] [PATCH 1/3] qtest: Enable creation of multiple qemu instances

2012-12-17 Thread Jason Baron
On Sat, Dec 15, 2012 at 09:20:13AM +, Blue Swirl wrote: > On Sat, Dec 15, 2012 at 9:14 AM, Paolo Bonzini wrote: > >> > +#define QTEST_FILE_TEMP "/tmp/qtest-%d.sock" > >> > +#define QTEST_QMP_FILE_TEMP "/tmp/qtest-%d.qmp" > >> > +#define QTEST_PID_FILE_TEMP "/tmp/qtest-%d.pid" > >> > >> These f

Re: [Qemu-devel] [PATCH 1/3] qtest: Enable creation of multiple qemu instances

2012-12-15 Thread Blue Swirl
On Sat, Dec 15, 2012 at 9:14 AM, Paolo Bonzini wrote: >> > +#define QTEST_FILE_TEMP "/tmp/qtest-%d.sock" >> > +#define QTEST_QMP_FILE_TEMP "/tmp/qtest-%d.qmp" >> > +#define QTEST_PID_FILE_TEMP "/tmp/qtest-%d.pid" >> >> These filenames are too predictable from security point of view, > > This need

Re: [Qemu-devel] [PATCH 1/3] qtest: Enable creation of multiple qemu instances

2012-12-15 Thread Paolo Bonzini
> > +#define QTEST_FILE_TEMP "/tmp/qtest-%d.sock" > > +#define QTEST_QMP_FILE_TEMP "/tmp/qtest-%d.qmp" > > +#define QTEST_PID_FILE_TEMP "/tmp/qtest-%d.pid" > > These filenames are too predictable from security point of view, This need not be secure as long as the file is created with 0600 permiss

Re: [Qemu-devel] [PATCH 1/3] qtest: Enable creation of multiple qemu instances

2012-12-14 Thread Blue Swirl
On Thu, Dec 13, 2012 at 10:02 PM, Jason Baron wrote: > From: Jason Baron > > Currently, the qtest harness can only spawn 1 qemu instance at a time because > the parent pid is used to create the socket files. Use the child pid instead, > so we can remove that limitation. > > Signed-off-by: Jason B

[Qemu-devel] [PATCH 1/3] qtest: Enable creation of multiple qemu instances

2012-12-13 Thread Jason Baron
From: Jason Baron Currently, the qtest harness can only spawn 1 qemu instance at a time because the parent pid is used to create the socket files. Use the child pid instead, so we can remove that limitation. Signed-off-by: Jason Baron --- tests/libqtest.c | 31 +--