Re: [Qemu-devel] [PATCH 1/3] qapi-visit: Simplify how we visit common union members

2016-01-27 Thread Eric Blake
On 01/27/2016 06:54 AM, Markus Armbruster wrote: > For a simple union SU, gen_visit_union() generates a visit of its > single tag member, like this: > > visit_type_SUKind(v, "type", &(*obj)->type, &err); > > For a flat union FU with base B, it generates a visit of its base > fields: > >

[Qemu-devel] [PATCH 1/3] qapi-visit: Simplify how we visit common union members

2016-01-27 Thread Markus Armbruster
For a simple union SU, gen_visit_union() generates a visit of its single tag member, like this: visit_type_SUKind(v, "type", &(*obj)->type, &err); For a flat union FU with base B, it generates a visit of its base fields: visit_type_B_fields(v, (B **)obj, &err); Instead, we can simply vi