Marc-André Lureau writes:
> Hi
>
> - Original Message -
>> Aha, we got a different bug fix! The old code fails to fail when the
>> parameter doesn't exist. Instead, it sets *obj = NULL, which seems very
>> likely to crash QEMU. Let me try... yup:
>>
>> { "execute": "object-add",
>
Hi
- Original Message -
> Aha, we got a different bug fix! The old code fails to fail when the
> parameter doesn't exist. Instead, it sets *obj = NULL, which seems very
> likely to crash QEMU. Let me try... yup:
>
> { "execute": "object-add",
> "arguments": { "qom-type": "mem
Hi
- Original Message -
> Marc-André Lureau writes:
>
> > The 'old' dispatch code returned a QERR_MISSING_PARAMETER for missing
> > parameters, but the qapi qmp_dispatch() code uses
> > QERR_INVALID_PARAMETER_TYPE.
> >
> > Improve qapi code to return QERR_INVALID_PARAMETER_TYPE where
> >
Marc-André Lureau writes:
> The 'old' dispatch code returned a QERR_MISSING_PARAMETER for missing
> parameters, but the qapi qmp_dispatch() code uses
> QERR_INVALID_PARAMETER_TYPE.
>
> Improve qapi code to return QERR_INVALID_PARAMETER_TYPE where
> appropriate.
>
> Signed-off-by: Marc-André Lurea
On Wed 21 Sep 2016 12:36:27 PM CEST, Marc-André Lureau wrote:
> The 'old' dispatch code returned a QERR_MISSING_PARAMETER for missing
> parameters, but the qapi qmp_dispatch() code uses
> QERR_INVALID_PARAMETER_TYPE.
>
> Improve qapi code to return QERR_INVALID_PARAMETER_TYPE where
> appropriate.
>
The 'old' dispatch code returned a QERR_MISSING_PARAMETER for missing
parameters, but the qapi qmp_dispatch() code uses
QERR_INVALID_PARAMETER_TYPE.
Improve qapi code to return QERR_INVALID_PARAMETER_TYPE where
appropriate.
Signed-off-by: Marc-André Lureau
---
qapi/qmp-input-visitor.c | 109 +++