Re: [Qemu-devel] [PATCH 1/3] pcie: don't skip multi-mask events

2019-07-01 Thread Philippe Mathieu-Daudé
On 6/21/19 8:46 AM, Michael S. Tsirkin wrote: > If we are trying to set multiple bits at once, testing that just one of > them is already set gives a false positive. As a result we won't > interrupt guest if e.g. presence detection change and attention button > press are both set. This happens with

Re: [Qemu-devel] [PATCH 1/3] pcie: don't skip multi-mask events

2019-07-01 Thread Marcel Apfelbaum
On 6/21/19 9:46 AM, Michael S. Tsirkin wrote: If we are trying to set multiple bits at once, testing that just one of them is already set gives a false positive. As a result we won't interrupt guest if e.g. presence detection change and attention button press are both set. This happens with mu

Re: [Qemu-devel] [PATCH 1/3] pcie: don't skip multi-mask events

2019-06-25 Thread Igor Mammedov
On Fri, 21 Jun 2019 02:46:46 -0400 "Michael S. Tsirkin" wrote: > If we are trying to set multiple bits at once, testing that just one of > them is already set gives a false positive. As a result we won't > interrupt guest if e.g. presence detection change and attention button > press are both set

[Qemu-devel] [PATCH 1/3] pcie: don't skip multi-mask events

2019-06-20 Thread Michael S. Tsirkin
If we are trying to set multiple bits at once, testing that just one of them is already set gives a false positive. As a result we won't interrupt guest if e.g. presence detection change and attention button press are both set. This happens with multi-function device removal. Signed-off-by: Michae