Re: [Qemu-devel] [PATCH 1/3] m25p80: do not put iovec on the stack

2016-06-28 Thread Eric Blake
On 06/28/2016 02:39 AM, Paolo Bonzini wrote: > When doing a read-modify-write cycle, QEMU uses the iovec after returning > from blk_aio_pwritev. m25p80 puts the iovec on the stack of blk_aio_pwritev's > caller, which causes trouble in this case. This has been a problem > since commit 243e6f6 ("m2

Re: [Qemu-devel] [PATCH 1/3] m25p80: do not put iovec on the stack

2016-06-28 Thread Cédric Le Goater
On 06/28/2016 10:53 AM, Cédric Le Goater wrote: > On 06/28/2016 10:39 AM, Paolo Bonzini wrote: >> When doing a read-modify-write cycle, QEMU uses the iovec after returning >> from blk_aio_pwritev. m25p80 puts the iovec on the stack of >> blk_aio_pwritev's >> caller, which causes trouble in this c

Re: [Qemu-devel] [PATCH 1/3] m25p80: do not put iovec on the stack

2016-06-28 Thread Cédric Le Goater
On 06/28/2016 10:39 AM, Paolo Bonzini wrote: > When doing a read-modify-write cycle, QEMU uses the iovec after returning > from blk_aio_pwritev. m25p80 puts the iovec on the stack of blk_aio_pwritev's > caller, which causes trouble in this case. This has been a problem > since commit 243e6f6 ("m2

[Qemu-devel] [PATCH 1/3] m25p80: do not put iovec on the stack

2016-06-28 Thread Paolo Bonzini
When doing a read-modify-write cycle, QEMU uses the iovec after returning from blk_aio_pwritev. m25p80 puts the iovec on the stack of blk_aio_pwritev's caller, which causes trouble in this case. This has been a problem since commit 243e6f6 ("m25p80: Switch to byte-based block access", 2016-05-12)