Re: [Qemu-devel] [PATCH 1/3] hw/sd/pxa2xx_mmci: convert to SysBusDevice object

2015-12-07 Thread Peter Maydell
On 7 December 2015 at 10:31, Markus Armbruster wrote: > Paolo Bonzini writes: > >> On 07/12/2015 09:50, Markus Armbruster wrote: >>> The device is obviously useful. However, there is dissent on how it >>> ought to be modelled. The modelling is visible at the -device user >>> interface. By maki

Re: [Qemu-devel] [PATCH 1/3] hw/sd/pxa2xx_mmci: convert to SysBusDevice object

2015-12-07 Thread Markus Armbruster
Paolo Bonzini writes: > On 07/12/2015 09:50, Markus Armbruster wrote: >> The device is obviously useful. However, there is dissent on how it >> ought to be modelled. The modelling is visible at the -device user >> interface. By making the device available there in 2.5, we commit to >> the curr

Re: [Qemu-devel] [PATCH 1/3] hw/sd/pxa2xx_mmci: convert to SysBusDevice object

2015-12-07 Thread Paolo Bonzini
On 07/12/2015 09:50, Markus Armbruster wrote: > The device is obviously useful. However, there is dissent on how it > ought to be modelled. The modelling is visible at the -device user > interface. By making the device available there in 2.5, we commit to > the current modelling's user interfa

Re: [Qemu-devel] [PATCH 1/3] hw/sd/pxa2xx_mmci: convert to SysBusDevice object

2015-12-07 Thread Markus Armbruster
"Kevin O'Connor" writes: > On Sun, Dec 06, 2015 at 04:02:14PM -0800, Peter Crosthwaite wrote: >> On Fri, Dec 4, 2015 at 11:24 AM, Kevin O'Connor wrote: >> > On Fri, Dec 04, 2015 at 10:50:21AM -0800, Peter Crosthwaite wrote: >> >> > FWIW, I don't think the SD card will be qdevified because it doe

Re: [Qemu-devel] [PATCH 1/3] hw/sd/pxa2xx_mmci: convert to SysBusDevice object

2015-12-06 Thread Kevin O'Connor
On Sun, Dec 06, 2015 at 04:02:14PM -0800, Peter Crosthwaite wrote: > On Fri, Dec 4, 2015 at 11:24 AM, Kevin O'Connor wrote: > > On Fri, Dec 04, 2015 at 10:50:21AM -0800, Peter Crosthwaite wrote: > >> > FWIW, I don't think the SD card will be qdevified because it doesn't > >> > need a bus. It's si

Re: [Qemu-devel] [PATCH 1/3] hw/sd/pxa2xx_mmci: convert to SysBusDevice object

2015-12-06 Thread Peter Crosthwaite
On Fri, Dec 4, 2015 at 11:24 AM, Kevin O'Connor wrote: > On Fri, Dec 04, 2015 at 10:50:21AM -0800, Peter Crosthwaite wrote: >> > FWIW, I don't think the SD card will be qdevified because it doesn't >> > need a bus. It's similar indeed to SerialState, which was supposed to >> > be the poster child

Re: [Qemu-devel] [PATCH 1/3] hw/sd/pxa2xx_mmci: convert to SysBusDevice object

2015-12-04 Thread Kevin O'Connor
On Fri, Dec 04, 2015 at 10:50:21AM -0800, Peter Crosthwaite wrote: > > FWIW, I don't think the SD card will be qdevified because it doesn't > > need a bus. It's similar indeed to SerialState, which was supposed to > > be the poster child of QOM embedding and never got QOMified. > > SD is a bus in

Re: [Qemu-devel] [PATCH 1/3] hw/sd/pxa2xx_mmci: convert to SysBusDevice object

2015-12-04 Thread Peter Crosthwaite
On Fri, Dec 4, 2015 at 8:42 AM, Paolo Bonzini wrote: > > > On 04/12/2015 12:00, Peter Maydell wrote: >> On 4 December 2015 at 07:30, Markus Armbruster wrote: >>> Peter Maydell writes: >>> On 7 September 2015 at 17:57, Markus Armbruster wrote: > Peter Maydell writes: > >> On 7

Re: [Qemu-devel] [PATCH 1/3] hw/sd/pxa2xx_mmci: convert to SysBusDevice object

2015-12-04 Thread Kevin O'Connor
On Fri, Dec 04, 2015 at 12:55:07PM +, Peter Maydell wrote: > On 4 December 2015 at 12:50, Markus Armbruster wrote: > > To finally answer your question: the proper owner of the property > > connecting the backend is the frontend half of the split device. So, if > > we have separate device mode

Re: [Qemu-devel] [PATCH 1/3] hw/sd/pxa2xx_mmci: convert to SysBusDevice object

2015-12-04 Thread Paolo Bonzini
On 04/12/2015 12:00, Peter Maydell wrote: > On 4 December 2015 at 07:30, Markus Armbruster wrote: >> Peter Maydell writes: >> >>> On 7 September 2015 at 17:57, Markus Armbruster wrote: Peter Maydell writes: > On 7 September 2015 at 17:40, Markus Armbruster wrote: >> Peter M

Re: [Qemu-devel] [PATCH 1/3] hw/sd/pxa2xx_mmci: convert to SysBusDevice object

2015-12-04 Thread Markus Armbruster
Peter Maydell writes: > On 4 December 2015 at 12:50, Markus Armbruster wrote: >> To finally answer your question: the proper owner of the property >> connecting the backend is the frontend half of the split device. So, if >> we have separate device models for controller and the block devices >>

Re: [Qemu-devel] [PATCH 1/3] hw/sd/pxa2xx_mmci: convert to SysBusDevice object

2015-12-04 Thread Peter Maydell
On 4 December 2015 at 12:50, Markus Armbruster wrote: > To finally answer your question: the proper owner of the property > connecting the backend is the frontend half of the split device. So, if > we have separate device models for controller and the block devices > connected to it, the block ba

Re: [Qemu-devel] [PATCH 1/3] hw/sd/pxa2xx_mmci: convert to SysBusDevice object

2015-12-04 Thread Markus Armbruster
Peter Maydell writes: > On 4 December 2015 at 07:30, Markus Armbruster wrote: >> Peter Maydell writes: >> >>> On 7 September 2015 at 17:57, Markus Armbruster wrote: Peter Maydell writes: > On 7 September 2015 at 17:40, Markus Armbruster wrote: >> Peter Maydell writes:

Re: [Qemu-devel] [PATCH 1/3] hw/sd/pxa2xx_mmci: convert to SysBusDevice object

2015-12-04 Thread Peter Maydell
On 4 December 2015 at 07:30, Markus Armbruster wrote: > Peter Maydell writes: > >> On 7 September 2015 at 17:57, Markus Armbruster wrote: >>> Peter Maydell writes: >>> On 7 September 2015 at 17:40, Markus Armbruster wrote: > Peter Maydell writes: > >> Convert the pxa2xx_mmci

Re: [Qemu-devel] [PATCH 1/3] hw/sd/pxa2xx_mmci: convert to SysBusDevice object

2015-12-03 Thread Markus Armbruster
Peter Maydell writes: > On 7 September 2015 at 17:57, Markus Armbruster wrote: >> Peter Maydell writes: >> >>> On 7 September 2015 at 17:40, Markus Armbruster wrote: Peter Maydell writes: > Convert the pxa2xx_mmci device to be a sysbus device. >>> > +static Property pxa2xx_m

Re: [Qemu-devel] [PATCH 1/3] hw/sd/pxa2xx_mmci: convert to SysBusDevice object

2015-12-03 Thread Peter Maydell
On 7 September 2015 at 17:57, Markus Armbruster wrote: > Peter Maydell writes: > >> On 7 September 2015 at 17:40, Markus Armbruster wrote: >>> Peter Maydell writes: >>> Convert the pxa2xx_mmci device to be a sysbus device. >> +static Property pxa2xx_mmci_properties[] = { +/*

Re: [Qemu-devel] [PATCH 1/3] hw/sd/pxa2xx_mmci: convert to SysBusDevice object

2015-09-07 Thread Peter Crosthwaite
On Mon, Sep 7, 2015 at 9:42 AM, Peter Maydell wrote: > On 7 September 2015 at 17:40, Markus Armbruster wrote: >> Peter Maydell writes: >> >>> Convert the pxa2xx_mmci device to be a sysbus device. > >>> +static Property pxa2xx_mmci_properties[] = { >>> +/* Note: pointer property 'drive' may r

Re: [Qemu-devel] [PATCH 1/3] hw/sd/pxa2xx_mmci: convert to SysBusDevice object

2015-09-07 Thread Markus Armbruster
Peter Maydell writes: > On 7 September 2015 at 17:40, Markus Armbruster wrote: >> Peter Maydell writes: >> >>> Convert the pxa2xx_mmci device to be a sysbus device. > >>> +static Property pxa2xx_mmci_properties[] = { >>> +/* Note: pointer property 'drive' may remain NULL, thus no need >>> +

Re: [Qemu-devel] [PATCH 1/3] hw/sd/pxa2xx_mmci: convert to SysBusDevice object

2015-09-07 Thread Peter Maydell
On 7 September 2015 at 17:40, Markus Armbruster wrote: > Peter Maydell writes: > >> Convert the pxa2xx_mmci device to be a sysbus device. >> +static Property pxa2xx_mmci_properties[] = { >> +/* Note: pointer property 'drive' may remain NULL, thus no need >> + * for dc->cannot_instantiate

Re: [Qemu-devel] [PATCH 1/3] hw/sd/pxa2xx_mmci: convert to SysBusDevice object

2015-09-07 Thread Markus Armbruster
Peter Maydell writes: > Convert the pxa2xx_mmci device to be a sysbus device. > > Signed-off-by: Peter Maydell > --- > hw/sd/pxa2xx_mmci.c | 96 > +++-- > 1 file changed, 79 insertions(+), 17 deletions(-) > > diff --git a/hw/sd/pxa2xx_mmci.c b/hw

[Qemu-devel] [PATCH 1/3] hw/sd/pxa2xx_mmci: convert to SysBusDevice object

2015-08-11 Thread Peter Maydell
Convert the pxa2xx_mmci device to be a sysbus device. Signed-off-by: Peter Maydell --- hw/sd/pxa2xx_mmci.c | 96 +++-- 1 file changed, 79 insertions(+), 17 deletions(-) diff --git a/hw/sd/pxa2xx_mmci.c b/hw/sd/pxa2xx_mmci.c index d1fe6d5..5b676c7