Re: [Qemu-devel] [PATCH 1/3] commit: Fix completion with extra reference

2017-06-09 Thread Eric Blake
On 06/09/2017 06:50 AM, Kevin Wolf wrote: > commit_complete() can't assume that after its block_job_completed() the > job is actually immediately freed; someone else may still be holding > references. In this case, the op blockers on the intermediate nodes make > the graph reconfiguration in the co

[Qemu-devel] [PATCH 1/3] commit: Fix completion with extra reference

2017-06-09 Thread Kevin Wolf
commit_complete() can't assume that after its block_job_completed() the job is actually immediately freed; someone else may still be holding references. In this case, the op blockers on the intermediate nodes make the graph reconfiguration in the completion code fail. Call block_job_remove_all_bdr