Re: [Qemu-devel] [PATCH 1/3] char: fix vhost-user socket full

2016-02-19 Thread Didier Pallard
On 02/10/2016 01:15 PM, Daniel P. Berrange wrote: On Wed, Feb 10, 2016 at 01:53:49PM +0200, Michael S. Tsirkin wrote: On Wed, Feb 10, 2016 at 10:35:13AM +0100, Didier Pallard wrote: On 02/09/2016 06:04 PM, Daniel P. Berrange wrote: On Tue, Feb 09, 2016 at 05:17:16PM +0100, Didier Pallard wrote

Re: [Qemu-devel] [PATCH 1/3] char: fix vhost-user socket full

2016-02-10 Thread Daniel P. Berrange
On Wed, Feb 10, 2016 at 01:53:49PM +0200, Michael S. Tsirkin wrote: > On Wed, Feb 10, 2016 at 10:35:13AM +0100, Didier Pallard wrote: > > On 02/09/2016 06:04 PM, Daniel P. Berrange wrote: > > >On Tue, Feb 09, 2016 at 05:17:16PM +0100, Didier Pallard wrote: > > >>On 02/09/2016 01:21 PM, Michael S. T

Re: [Qemu-devel] [PATCH 1/3] char: fix vhost-user socket full

2016-02-10 Thread Michael S. Tsirkin
On Wed, Feb 10, 2016 at 10:35:13AM +0100, Didier Pallard wrote: > On 02/09/2016 06:04 PM, Daniel P. Berrange wrote: > >On Tue, Feb 09, 2016 at 05:17:16PM +0100, Didier Pallard wrote: > >>On 02/09/2016 01:21 PM, Michael S. Tsirkin wrote: > >>>On Tue, Feb 09, 2016 at 11:48:13AM +, Daniel P. Berra

Re: [Qemu-devel] [PATCH 1/3] char: fix vhost-user socket full

2016-02-10 Thread Didier Pallard
On 02/09/2016 06:04 PM, Daniel P. Berrange wrote: On Tue, Feb 09, 2016 at 05:17:16PM +0100, Didier Pallard wrote: On 02/09/2016 01:21 PM, Michael S. Tsirkin wrote: On Tue, Feb 09, 2016 at 11:48:13AM +, Daniel P. Berrange wrote: On Thu, Feb 04, 2016 at 04:10:38PM +0200, Michael S. Tsirkin w

Re: [Qemu-devel] [PATCH 1/3] char: fix vhost-user socket full

2016-02-09 Thread Daniel P. Berrange
On Tue, Feb 09, 2016 at 05:17:16PM +0100, Didier Pallard wrote: > On 02/09/2016 01:21 PM, Michael S. Tsirkin wrote: > >On Tue, Feb 09, 2016 at 11:48:13AM +, Daniel P. Berrange wrote: > >>On Thu, Feb 04, 2016 at 04:10:38PM +0200, Michael S. Tsirkin wrote: > >>>On Thu, Dec 03, 2015 at 10:53:17AM

Re: [Qemu-devel] [PATCH 1/3] char: fix vhost-user socket full

2016-02-09 Thread Michael S. Tsirkin
On Tue, Feb 09, 2016 at 05:17:16PM +0100, Didier Pallard wrote: > On 02/09/2016 01:21 PM, Michael S. Tsirkin wrote: > >On Tue, Feb 09, 2016 at 11:48:13AM +, Daniel P. Berrange wrote: > >>On Thu, Feb 04, 2016 at 04:10:38PM +0200, Michael S. Tsirkin wrote: > >>>On Thu, Dec 03, 2015 at 10:53:17AM

Re: [Qemu-devel] [PATCH 1/3] char: fix vhost-user socket full

2016-02-09 Thread Didier Pallard
On 02/09/2016 01:21 PM, Michael S. Tsirkin wrote: On Tue, Feb 09, 2016 at 11:48:13AM +, Daniel P. Berrange wrote: On Thu, Feb 04, 2016 at 04:10:38PM +0200, Michael S. Tsirkin wrote: On Thu, Dec 03, 2015 at 10:53:17AM +0100, Didier Pallard wrote: unix_send_msgfds is used by vhost-user contr

Re: [Qemu-devel] [PATCH 1/3] char: fix vhost-user socket full

2016-02-09 Thread Michael S. Tsirkin
On Tue, Feb 09, 2016 at 11:48:13AM +, Daniel P. Berrange wrote: > On Thu, Feb 04, 2016 at 04:10:38PM +0200, Michael S. Tsirkin wrote: > > On Thu, Dec 03, 2015 at 10:53:17AM +0100, Didier Pallard wrote: > > > unix_send_msgfds is used by vhost-user control socket. > > > qemu_chr_fe_write_all > >

Re: [Qemu-devel] [PATCH 1/3] char: fix vhost-user socket full

2016-02-09 Thread Daniel P. Berrange
On Thu, Feb 04, 2016 at 04:10:38PM +0200, Michael S. Tsirkin wrote: > On Thu, Dec 03, 2015 at 10:53:17AM +0100, Didier Pallard wrote: > > unix_send_msgfds is used by vhost-user control socket. qemu_chr_fe_write_all > > is used to send a message and retries as long as EAGAIN errno is set, > > but wr

Re: [Qemu-devel] [PATCH 1/3] char: fix vhost-user socket full

2016-02-09 Thread Michael S. Tsirkin
On Mon, Feb 08, 2016 at 02:12:14PM +0100, Didier Pallard wrote: > On 02/04/2016 03:10 PM, Michael S. Tsirkin wrote: > >On Thu, Dec 03, 2015 at 10:53:17AM +0100, Didier Pallard wrote: > >>unix_send_msgfds is used by vhost-user control socket. qemu_chr_fe_write_all > >>is used to send a message and r

Re: [Qemu-devel] [PATCH 1/3] char: fix vhost-user socket full

2016-02-08 Thread Didier Pallard
On 02/04/2016 03:10 PM, Michael S. Tsirkin wrote: On Thu, Dec 03, 2015 at 10:53:17AM +0100, Didier Pallard wrote: unix_send_msgfds is used by vhost-user control socket. qemu_chr_fe_write_all is used to send a message and retries as long as EAGAIN errno is set, but write_msgfds buffer is freed af

Re: [Qemu-devel] [PATCH 1/3] char: fix vhost-user socket full

2016-02-04 Thread Michael S. Tsirkin
On Thu, Dec 03, 2015 at 10:53:17AM +0100, Didier Pallard wrote: > unix_send_msgfds is used by vhost-user control socket. qemu_chr_fe_write_all > is used to send a message and retries as long as EAGAIN errno is set, > but write_msgfds buffer is freed after first EAGAIN failure, causing > message to

Re: [Qemu-devel] [PATCH 1/3] char: fix vhost-user socket full

2016-02-04 Thread Michael S. Tsirkin
On Thu, Dec 03, 2015 at 10:53:17AM +0100, Didier Pallard wrote: > unix_send_msgfds is used by vhost-user control socket. qemu_chr_fe_write_all > is used to send a message and retries as long as EAGAIN errno is set, > but write_msgfds buffer is freed after first EAGAIN failure, causing > message to

Re: [Qemu-devel] [PATCH 1/3] char: fix vhost-user socket full

2015-12-17 Thread Victor Kaplansky
On Thu, Dec 10, 2015 at 04:09:23PM +0100, Didier Pallard wrote: > On 12/10/2015 01:56 PM, Victor Kaplansky wrote: > >On Wed, Dec 09, 2015 at 06:06:06PM +0100, Didier Pallard wrote: > >>On 12/09/2015 04:59 PM, Victor Kaplansky wrote: > >>>On Mon, Dec 07, 2015 at 02:31:36PM +0100, Marc-André Lureau w

Re: [Qemu-devel] [PATCH 1/3] char: fix vhost-user socket full

2015-12-10 Thread Didier Pallard
On 12/10/2015 01:56 PM, Victor Kaplansky wrote: On Wed, Dec 09, 2015 at 06:06:06PM +0100, Didier Pallard wrote: On 12/09/2015 04:59 PM, Victor Kaplansky wrote: On Mon, Dec 07, 2015 at 02:31:36PM +0100, Marc-André Lureau wrote: Hi On Thu, Dec 3, 2015 at 10:53 AM, Didier Pallard wrote: unix_s

Re: [Qemu-devel] [PATCH 1/3] char: fix vhost-user socket full

2015-12-10 Thread Victor Kaplansky
On Wed, Dec 09, 2015 at 06:06:06PM +0100, Didier Pallard wrote: > On 12/09/2015 04:59 PM, Victor Kaplansky wrote: > >On Mon, Dec 07, 2015 at 02:31:36PM +0100, Marc-André Lureau wrote: > >>Hi > >> > >>On Thu, Dec 3, 2015 at 10:53 AM, Didier Pallard > >> wrote: > >>>unix_send_msgfds is used by vhost-

Re: [Qemu-devel] [PATCH 1/3] char: fix vhost-user socket full

2015-12-09 Thread Didier Pallard
On 12/09/2015 04:59 PM, Victor Kaplansky wrote: On Mon, Dec 07, 2015 at 02:31:36PM +0100, Marc-André Lureau wrote: Hi On Thu, Dec 3, 2015 at 10:53 AM, Didier Pallard wrote: unix_send_msgfds is used by vhost-user control socket. qemu_chr_fe_write_all is used to send a message and retries as lo

Re: [Qemu-devel] [PATCH 1/3] char: fix vhost-user socket full

2015-12-09 Thread Victor Kaplansky
On Mon, Dec 07, 2015 at 02:31:36PM +0100, Marc-André Lureau wrote: > Hi > > On Thu, Dec 3, 2015 at 10:53 AM, Didier Pallard > wrote: > > unix_send_msgfds is used by vhost-user control socket. qemu_chr_fe_write_all > > is used to send a message and retries as long as EAGAIN errno is set, > > but w

Re: [Qemu-devel] [PATCH 1/3] char: fix vhost-user socket full

2015-12-07 Thread Marc-André Lureau
Hi On Thu, Dec 3, 2015 at 10:53 AM, Didier Pallard wrote: > unix_send_msgfds is used by vhost-user control socket. qemu_chr_fe_write_all > is used to send a message and retries as long as EAGAIN errno is set, > but write_msgfds buffer is freed after first EAGAIN failure, causing > message to be s

[Qemu-devel] [PATCH 1/3] char: fix vhost-user socket full

2015-12-03 Thread Didier Pallard
unix_send_msgfds is used by vhost-user control socket. qemu_chr_fe_write_all is used to send a message and retries as long as EAGAIN errno is set, but write_msgfds buffer is freed after first EAGAIN failure, causing message to be sent without proper fds attachment. In case unix_send_msgfds is call