Re: [Qemu-devel] [PATCH 1/3] blockdev: abort transactions in reverse order

2018-12-07 Thread Vladimir Sementsov-Ogievskiy
06.12.2018 22:25, John Snow wrote: > Presently, we abort transactions in the same order they were processed in. > Bitmap commands, though, attempt to restore backup data structures on abort. > To that end, though, they need to be aborted in reverse chronological order. > > Replace the QSIMPLEQ dat

Re: [Qemu-devel] [PATCH 1/3] blockdev: abort transactions in reverse order

2018-12-06 Thread John Snow
On 12/6/18 3:37 PM, Eric Blake wrote: > On 12/6/18 1:25 PM, John Snow wrote: >> Presently, we abort transactions in the same order they were processed >> in. >> Bitmap commands, though, attempt to restore backup data structures on >> abort. >> To that end, though, they need to be aborted in reve

Re: [Qemu-devel] [PATCH 1/3] blockdev: abort transactions in reverse order

2018-12-06 Thread Eric Blake
On 12/6/18 1:25 PM, John Snow wrote: Presently, we abort transactions in the same order they were processed in. Bitmap commands, though, attempt to restore backup data structures on abort. To that end, though, they need to be aborted in reverse chronological order. Replace the QSIMPLEQ data stru

[Qemu-devel] [PATCH 1/3] blockdev: abort transactions in reverse order

2018-12-06 Thread John Snow
Presently, we abort transactions in the same order they were processed in. Bitmap commands, though, attempt to restore backup data structures on abort. To that end, though, they need to be aborted in reverse chronological order. Replace the QSIMPLEQ data structure with a QTAILQ one, so we can iter