Re: [Qemu-devel] [PATCH 1/3] block: Support streaming to an intermediate layer

2015-03-12 Thread Alberto Garcia
(Ccing Markus and Jeff as suggested) On Thu, Mar 05, 2015 at 03:04:25PM +0100, Kevin Wolf wrote: > My question is whether we can't simply call stream_start() with an > intermediate node as bs instead of introducing a new parameter. I'm > not completely sure about the consequences of 3., i.e. movi

Re: [Qemu-devel] [PATCH 1/3] block: Support streaming to an intermediate layer

2015-03-05 Thread Kevin Wolf
Am 05.03.2015 um 15:58 hat Alberto Garcia geschrieben: > On Thu, Mar 05, 2015 at 03:04:25PM +0100, Kevin Wolf wrote: > > > The bs parameter is now only used for the following things: > > > > 1. As the default for top > > Right. > > > 2. For error handling: Any errors are reported for bs, even t

Re: [Qemu-devel] [PATCH 1/3] block: Support streaming to an intermediate layer

2015-03-05 Thread Alberto Garcia
On Thu, Mar 05, 2015 at 04:15:52PM +0100, Kevin Wolf wrote: > > > 3. As the BDS that owns the job > > > > > > My question is whether we can't simply call stream_start() > > > with an intermediate node as bs instead of introducing a new > > > parameter. I'm not completely sure about the consequenc

Re: [Qemu-devel] [PATCH 1/3] block: Support streaming to an intermediate layer

2015-03-05 Thread Alberto Garcia
On Thu, Mar 05, 2015 at 03:04:25PM +0100, Kevin Wolf wrote: > The bs parameter is now only used for the following things: > > 1. As the default for top Right. > 2. For error handling: Any errors are reported for bs, even though >they are actually for top. Is this correct behaviour? It looks

Re: [Qemu-devel] [PATCH 1/3] block: Support streaming to an intermediate layer

2015-03-05 Thread Kevin Wolf
Am 20.02.2015 um 14:53 hat Alberto Garcia geschrieben: > This adds a new 'top' parameter to stream_start(), that specifies the > block device where the data will be written. The image is changed to > read-write mode during the streaming and back to read-only afterwards. > > This also unblocks the

[Qemu-devel] [PATCH 1/3] block: Support streaming to an intermediate layer

2015-02-20 Thread Alberto Garcia
This adds a new 'top' parameter to stream_start(), that specifies the block device where the data will be written. The image is changed to read-write mode during the streaming and back to read-only afterwards. This also unblocks the stream operation in backing files. Signed-off-by: Alberto Garcia