Re: [Qemu-devel] [PATCH 1/3] archive-source.sh: Drop submodule code

2018-04-04 Thread Fam Zheng
On Wed, 04/04 10:24, Daniel P. Berrangé wrote: > On Wed, Apr 04, 2018 at 05:07:56PM +0800, Fam Zheng wrote: > > On Wed, 04/04 09:23, Daniel P. Berrangé wrote: > > > On Wed, Apr 04, 2018 at 10:51:59AM +0800, Fam Zheng wrote: > > > > ./configure and make now take care of submodules, we only need to c

Re: [Qemu-devel] [PATCH 1/3] archive-source.sh: Drop submodule code

2018-04-04 Thread Daniel P . Berrangé
On Wed, Apr 04, 2018 at 05:07:56PM +0800, Fam Zheng wrote: > On Wed, 04/04 09:23, Daniel P. Berrangé wrote: > > On Wed, Apr 04, 2018 at 10:51:59AM +0800, Fam Zheng wrote: > > > ./configure and make now take care of submodules, we only need to clone > > > the top tree. > > > > If you don't include

Re: [Qemu-devel] [PATCH 1/3] archive-source.sh: Drop submodule code

2018-04-04 Thread Fam Zheng
On Wed, 04/04 09:23, Daniel P. Berrangé wrote: > On Wed, Apr 04, 2018 at 10:51:59AM +0800, Fam Zheng wrote: > > ./configure and make now take care of submodules, we only need to clone > > the top tree. > > If you don't include the submodules in the tar.gz archive, then the > test system needs to b

Re: [Qemu-devel] [PATCH 1/3] archive-source.sh: Drop submodule code

2018-04-04 Thread Daniel P . Berrangé
On Wed, Apr 04, 2018 at 10:51:59AM +0800, Fam Zheng wrote: > ./configure and make now take care of submodules, we only need to clone > the top tree. If you don't include the submodules in the tar.gz archive, then the test system needs to be able to clone them from qemu.org, which requires networki

[Qemu-devel] [PATCH 1/3] archive-source.sh: Drop submodule code

2018-04-03 Thread Fam Zheng
./configure and make now take care of submodules, we only need to clone the top tree. Signed-off-by: Fam Zheng --- scripts/archive-source.sh | 47 --- 1 file changed, 4 insertions(+), 43 deletions(-) diff --git a/scripts/archive-source.sh b/scripts/ar