Re: [Qemu-devel] [PATCH 1/3] Target-microblaze: Remove unnecessary variable

2015-10-05 Thread Peter Maydell
On 5 October 2015 at 08:18, Michael Tokarev wrote: > 05.10.2015 08:18, Markus Armbruster wrote: >> Why? I like having the semantic patch in the commit message when >> there's any chance we'll want do the same mechanical change again later. >> >> You could save space and include it by reference, t

Re: [Qemu-devel] [PATCH 1/3] Target-microblaze: Remove unnecessary variable

2015-10-05 Thread Michael Tokarev
05.10.2015 08:18, Markus Armbruster wrote: > Michael Tokarev writes: > >> 25.09.2015 11:37, Shraddha Barke wrote: >>> Compress lines and remove the variable . >> >> Applied to -trivial, removing this piece of commit message: >> >> --- >>> Change made using Coccinelle script [..snip..] >> --- > >

Re: [Qemu-devel] [PATCH 1/3] Target-microblaze: Remove unnecessary variable

2015-10-04 Thread Markus Armbruster
Michael Tokarev writes: > 25.09.2015 11:37, Shraddha Barke wrote: >> Compress lines and remove the variable . > > Applied to -trivial, removing this piece of commit message: > > --- >> Change made using Coccinelle script >> >> @@ >> expression ret; >> @@ >> - if (ret) return ret; >> - return 0;

Re: [Qemu-devel] [PATCH 1/3] Target-microblaze: Remove unnecessary variable

2015-10-03 Thread Michael Tokarev
25.09.2015 11:37, Shraddha Barke wrote: > Compress lines and remove the variable . Applied to -trivial, removing this piece of commit message: --- > Change made using Coccinelle script > > @@ > expression ret; > @@ > - if (ret) return ret; > - return 0; > + return ret; > @@ > local idexpression

[Qemu-devel] [PATCH 1/3] Target-microblaze: Remove unnecessary variable

2015-09-25 Thread Shraddha Barke
Compress lines and remove the variable . Change made using Coccinelle script @@ expression ret; @@ - if (ret) return ret; - return 0; + return ret; @@ local idexpression ret; expression e; @@ - ret = e; - return ret; + return e; @@ type T; identifier i; @@ - T i; ... when != i Signed-off-by: Shr