On Mon, Dec 6, 2010 at 10:47 AM, Jes Sorensen wrote:
> On 12/06/10 11:37, Stefan Hajnoczi wrote:
>> On Mon, Dec 6, 2010 at 10:20 AM, Jes Sorensen
>> wrote:
>>> On 12/06/10 10:32, Stefan Hajnoczi wrote:
On Mon, Dec 6, 2010 at 8:17 AM, wrote:
Why goto out2 and not just return like the
On 12/06/10 11:37, Stefan Hajnoczi wrote:
> On Mon, Dec 6, 2010 at 10:20 AM, Jes Sorensen wrote:
>> On 12/06/10 10:32, Stefan Hajnoczi wrote:
>>> On Mon, Dec 6, 2010 at 8:17 AM, wrote:
>>> Why goto out2 and not just return like the bs > 1 && out_baseimg check?
>>
>> It is cleaner, I'd rather con
On Mon, Dec 6, 2010 at 10:20 AM, Jes Sorensen wrote:
> On 12/06/10 10:32, Stefan Hajnoczi wrote:
>> On Mon, Dec 6, 2010 at 8:17 AM, wrote:
>>> @@ -694,6 +721,11 @@ static int img_convert(int argc, char **argv)
>>>
>>> out_filename = argv[argc - 1];
>>>
>>> + if (options && !strcmp(options
On 12/06/10 10:32, Stefan Hajnoczi wrote:
> On Mon, Dec 6, 2010 at 8:17 AM, wrote:
>> @@ -694,6 +721,11 @@ static int img_convert(int argc, char **argv)
>>
>> out_filename = argv[argc - 1];
>>
>> +if (options && !strcmp(options, "?")) {
>> +ret = print_block_option_help(out_filena
On Mon, Dec 6, 2010 at 8:17 AM, wrote:
> @@ -694,6 +721,11 @@ static int img_convert(int argc, char **argv)
>
> out_filename = argv[argc - 1];
>
> + if (options && !strcmp(options, "?")) {
> + ret = print_block_option_help(out_filename, out_fmt);
> + goto out2;
> + }
> +
>
From: Jes Sorensen
This consolidates the printing of block driver options in
print_block_option_help() which is called from both img_create() and
img_convert().
This allows for the "?" detection to be done just after the parsing of
options and the filename, instead of half way down the codepath
On Fri, Dec 3, 2010 at 10:57 AM, Stefan Hajnoczi wrote:
> On Thu, Dec 2, 2010 at 5:46 PM, wrote:
>> @@ -694,6 +720,11 @@ static int img_convert(int argc, char **argv)
>>
>> out_filename = argv[argc - 1];
>>
>> + if (options && !strcmp(options, "?")) {
>> + ret = print_block_option_
On 12/03/10 11:57, Stefan Hajnoczi wrote:
> On Thu, Dec 2, 2010 at 5:46 PM, wrote:
>> +create_options = append_option_parameters(create_options,
>> + drv->create_options);
>> +create_options = append_option_parameters(create_options,
>> +
On Thu, Dec 2, 2010 at 5:46 PM, wrote:
> @@ -188,6 +188,32 @@ static int read_password(char *buf, int buf_size)
> }
> #endif
>
> +static int print_block_option_help(const char *filename, const char *fmt)
> +{
> + BlockDriver *drv, *proto_drv;
> + QEMUOptionParameter *create_options = NULL
From: Jes Sorensen
This consolidates the printing of block driver options in
print_block_option_help() which is called from both img_create() and
img_convert().
This allows for the "?" detection to be done just after the parsing of
options and the filename, instead of half way down the codepath
10 matches
Mail list logo
