Re: [Qemu-devel] [PATCH 1/3] Check for Linux USBFS in configure

2018-10-04 Thread Cortland Setlow Tölva
Hi Laurent, The deeper view on part 3 can wait - I have found an issue with 64-bit hosts. In linux-user/syscall_defs.h the references to struct usbdevfs_urb and so forth are incorrect and I need to define struct target_usbdevfs_urb for the size and the ioctl code to be calculated with the target'

Re: [Qemu-devel] [PATCH 1/3] Check for Linux USBFS in configure

2018-09-24 Thread Laurent Vivier
Le 23/09/2018 à 06:44, Blake Tölva a écrit : > Thanks Laurent, I have updated the patch. Should I resend the whole > series to the list? yes. > I believe the third patch may also need revision as the call to > thunk_convert at the end > of do_ioctl_usbdevfs_reapurb seems clunky. Would love some

Re: [Qemu-devel] [PATCH 1/3] Check for Linux USBFS in configure

2018-09-22 Thread Blake Tölva
Thanks Laurent, I have updated the patch. Should I resend the whole series to the list? I believe the third patch may also need revision as the call to thunk_convert at the end of do_ioctl_usbdevfs_reapurb seems clunky. Would love some comments. On Wed, Sep 19, 2018 at 6:49 AM, Laurent Vivier w

Re: [Qemu-devel] [PATCH 1/3] Check for Linux USBFS in configure

2018-09-19 Thread Laurent Vivier
Le 19/09/2018 à 15:39, Laurent Vivier a écrit : > Le 19/09/2018 à 10:04, Cortland Tölva a écrit : >> In preparation for adding user mode emulation support for the >> Linux usbfs interface, check for its kernel header. >> >> Signed-off-by: Cortland Tölva >> --- >> configure | 21 ++

Re: [Qemu-devel] [PATCH 1/3] Check for Linux USBFS in configure

2018-09-19 Thread Laurent Vivier
Le 19/09/2018 à 10:04, Cortland Tölva a écrit : > In preparation for adding user mode emulation support for the > Linux usbfs interface, check for its kernel header. > > Signed-off-by: Cortland Tölva > --- > configure | 21 - > 1 file changed, 20 insertions(+), 1 deletion(-)

[Qemu-devel] [PATCH 1/3] Check for Linux USBFS in configure

2018-09-19 Thread Cortland Tölva
In preparation for adding user mode emulation support for the Linux usbfs interface, check for its kernel header. Signed-off-by: Cortland Tölva --- configure | 21 - 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 58862d2ae8..5d36f454