On Mon, Sep 15, 2014 at 12:40:07PM +0200, Gerd Hoffmann wrote:
> > > > > +
> > > > > +enum virtgpu_ctrl_type {
> > > > > +VIRTGPU_UNDEFINED = 0,
> > > > > +
> > > > > +/* 2d commands */
> > > > > +VIRTGPU_CMD_GET_DISPLAY_INFO = 0x0100,
> > > >
> > > > Please consider also a
> > > > +
> > > > +enum virtgpu_ctrl_type {
> > > > +VIRTGPU_UNDEFINED = 0,
> > > > +
> > > > +/* 2d commands */
> > > > +VIRTGPU_CMD_GET_DISPLAY_INFO = 0x0100,
> > >
> > > Please consider also adding:
>
> VIRTIO_GPU_ everywhere to make it consistent with other
> virtio he
Hi,
> >>
> >> Why do you think that? We have several header files which
> >> use QEMU_BUILD_BUG_ON and I don't see any reason why
> >> it would have to be invoked from a .c file.
>
> > Because Gerd wants to share this with linux uapi, and
> > you can't use BUILD_BUG_ON in uapi headers on linux.
On Sun, Sep 14, 2014 at 09:11:45AM -0700, Peter Maydell wrote:
> On 14 September 2014 08:09, Michael S. Tsirkin wrote:
> > On Sun, Sep 14, 2014 at 07:32:21AM -0700, Peter Maydell wrote:
> >> Who owns the "master" copy of the header and commits
> >> to making sure it builds on other things than Lin
On 14 September 2014 08:09, Michael S. Tsirkin wrote:
> On Sun, Sep 14, 2014 at 07:32:21AM -0700, Peter Maydell wrote:
>> Who owns the "master" copy of the header and commits
>> to making sure it builds on other things than Linux+gcc
>> in that case?
> For most of virtio neither linux nor QEMU ar
On Sun, Sep 14, 2014 at 07:32:21AM -0700, Peter Maydell wrote:
> On 14 September 2014 07:11, Michael S. Tsirkin wrote:
> > On Sun, Sep 14, 2014 at 07:04:11AM -0700, Peter Maydell wrote:
> >> On 14 September 2014 06:46, Michael S. Tsirkin wrote:
> >> > BUILD_BUG_ON in linux, QEMU_BUILD_BUG_ON in Q
On 14 September 2014 07:11, Michael S. Tsirkin wrote:
> On Sun, Sep 14, 2014 at 07:04:11AM -0700, Peter Maydell wrote:
>> On 14 September 2014 06:46, Michael S. Tsirkin wrote:
>> > BUILD_BUG_ON in linux, QEMU_BUILD_BUG_ON in QEMU.
>> > You have to stick it in a C file though, so it
>> > won't be
On Sun, Sep 14, 2014 at 07:04:11AM -0700, Peter Maydell wrote:
> On 14 September 2014 06:46, Michael S. Tsirkin wrote:
> > BUILD_BUG_ON in linux, QEMU_BUILD_BUG_ON in QEMU.
> > You have to stick it in a C file though, so it
> > won't be visible in this patch.
>
> Why do you think that? We have se
On 14 September 2014 06:46, Michael S. Tsirkin wrote:
> BUILD_BUG_ON in linux, QEMU_BUILD_BUG_ON in QEMU.
> You have to stick it in a C file though, so it
> won't be visible in this patch.
Why do you think that? We have several header files which
use QEMU_BUILD_BUG_ON and I don't see any reason w
On Fri, Sep 12, 2014 at 12:44:56PM +0200, Gerd Hoffmann wrote:
> Hi,
>
> > > @@ -0,0 +1,158 @@
> > > +#ifndef VIRTGPU_HW_H
> > > +#define VIRTGPU_HW_H
> >
> > Non-trivial file, deserves a copyright and license notice.
>
> Added.
Pls remember to make it consistent with other virtio headers,
wh
On 12 September 2014 13:48, Eric Blake wrote:
> On 09/12/2014 04:44 AM, Gerd Hoffmann wrote:
>
+enum virtgpu_ctrl_type {
+VIRTGPU_UNDEFINED = 0,
+
+/* 2d commands */
+VIRTGPU_CMD_GET_DISPLAY_INFO = 0x0100,
>>>
>>> Please consider also adding:
>>>
>>
On 09/12/2014 06:48 AM, Eric Blake wrote:
> So if you need more ideas and a good read, check out
> the comments in how gnulib does it (the link mentions GPLv3+, but that
> file is also shipped as LGPLv2+ so it is compatible with qemu):
>
> git.savannah.gnu.org/cgit/gnulib.git/tree/lib/verify.h
J
On 09/12/2014 04:44 AM, Gerd Hoffmann wrote:
>>> +enum virtgpu_ctrl_type {
>>> +VIRTGPU_UNDEFINED = 0,
>>> +
>>> +/* 2d commands */
>>> +VIRTGPU_CMD_GET_DISPLAY_INFO = 0x0100,
>>
>> Please consider also adding:
>>
>> #define VIRTGPU_CMD_GET_DISPLAY_INFO VIRTGPU_CMD_GET_DISP
Hi,
> > @@ -0,0 +1,158 @@
> > +#ifndef VIRTGPU_HW_H
> > +#define VIRTGPU_HW_H
>
> Non-trivial file, deserves a copyright and license notice.
Added.
> > +
> > +enum virtgpu_ctrl_type {
> > +VIRTGPU_UNDEFINED = 0,
> > +
> > +/* 2d commands */
> > +VIRTGPU_CMD_GET_DISPLAY
On 09/11/2014 11:43 AM, Gerd Hoffmann wrote:
> On Do, 2014-09-11 at 16:20 +0100, Peter Maydell wrote:
>> On 11 September 2014 16:09, Gerd Hoffmann wrote:
>>> This patch adds the header file with structs and defines for
>>> the virtio based gpu device. Covers 2d operations only.
>>
>> Please don't
On Do, 2014-09-11 at 16:20 +0100, Peter Maydell wrote:
> On 11 September 2014 16:09, Gerd Hoffmann wrote:
> > This patch adds the header file with structs and defines for
> > the virtio based gpu device. Covers 2d operations only.
>
> Please don't cc subscriber only mailing lists
> (virtio-...@l
Hi,
> > +enum virtgpu_ctrl_type {
> > +VIRTGPU_UNDEFINED = 0,
> >
>
> This is clearly all well out of line with our
> coding style guide, which isn't a terribly good start...
Oh yea, code style is fun. This file is needed in both qemu & linux
kernel, which have different code styles.
On 11 September 2014 16:09, Gerd Hoffmann wrote:
> This patch adds the header file with structs and defines for
> the virtio based gpu device. Covers 2d operations only.
Please don't cc subscriber only mailing lists
(virtio-...@lists.oasis-open.org) on posts to qemu-devel;
it just means everybod
On 09/11/2014 09:09 AM, Gerd Hoffmann wrote:
> This patch adds the header file with structs and defines for
> the virtio based gpu device. Covers 2d operations only.
>
> Signed-off-by: Gerd Hoffmann
> ---
> include/hw/virtio/virtgpu_hw.h | 158
> +
> 1 f
On 11 September 2014 16:09, Gerd Hoffmann wrote:
> This patch adds the header file with structs and defines for
> the virtio based gpu device. Covers 2d operations only.
>
> Signed-off-by: Gerd Hoffmann
> ---
> include/hw/virtio/virtgpu_hw.h | 158
> +
>
This patch adds the header file with structs and defines for
the virtio based gpu device. Covers 2d operations only.
Signed-off-by: Gerd Hoffmann
---
include/hw/virtio/virtgpu_hw.h | 158 +
1 file changed, 158 insertions(+)
create mode 100644 include/hw/
21 matches
Mail list logo
