Re: [Qemu-devel] [PATCH 1/2] trace: portable simple trace backend using glib

2011-09-20 Thread Stefan Hajnoczi
On Tue, Sep 20, 2011 at 11:58 AM, Jan Kiszka wrote: > On 2011-09-20 12:52, Paolo Bonzini wrote: >> On 09/20/2011 12:31 PM, Jan Kiszka wrote: >>> Please avoid restrictive glib thread services. We have qemu_thread >>> abstractions that allow central tuning (will be needed e.g. to adjust >>> scheduli

Re: [Qemu-devel] [PATCH 1/2] trace: portable simple trace backend using glib

2011-09-20 Thread Jan Kiszka
On 2011-09-20 12:52, Paolo Bonzini wrote: > On 09/20/2011 12:31 PM, Jan Kiszka wrote: >> Please avoid restrictive glib thread services. We have qemu_thread >> abstractions that allow central tuning (will be needed e.g. to adjust >> scheduling parameters). > > I think the rationale here was to allo

Re: [Qemu-devel] [PATCH 1/2] trace: portable simple trace backend using glib

2011-09-20 Thread Paolo Bonzini
On 09/20/2011 12:31 PM, Jan Kiszka wrote: Please avoid restrictive glib thread services. We have qemu_thread abstractions that allow central tuning (will be needed e.g. to adjust scheduling parameters). I think the rationale here was to allow tracing the qemu_thread routines. For your applica

Re: [Qemu-devel] [PATCH 1/2] trace: portable simple trace backend using glib

2011-09-20 Thread Jan Kiszka
On 2011-09-09 11:37, Stefan Hajnoczi wrote: > Convert the simple trace backend to glib so that it works under Windows. > We cannot use pthread directly but glib provides portable abstractions. > Also use glib atomics instead of newish gcc builtins which may not be > supported on Windows toolchains.

[Qemu-devel] [PATCH 1/2] trace: portable simple trace backend using glib

2011-09-09 Thread Stefan Hajnoczi
Convert the simple trace backend to glib so that it works under Windows. We cannot use pthread directly but glib provides portable abstractions. Also use glib atomics instead of newish gcc builtins which may not be supported on Windows toolchains. Signed-off-by: Stefan Hajnoczi --- trace/simple.